Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): update FW alert on Home + remote feature flag #16318

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat(mobile): update FW alert on Home + remote feature flag #16318

merged 2 commits into from
Jan 17, 2025

Conversation

Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Jan 12, 2025 •
edited
Loading

Description

  1. Added update alert box to Homescreen
  2. Added remote feature flag for message system to disable => tested with local JWS config
  3. Removed local feature flag in favor of remote one

Related Issue

Resolve part of #15584

Screenshots:

screen-20250113-145307.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 22
  • More info

Learn more about 𝝠 Expo Github Action

@Nodonisko Nodonisko force-pushed the feat/update-firmware-alert branch from cb30b94 to 215e8f9 Compare January 13, 2025 14:22
@Nodonisko Nodonisko marked this pull request as ready for review January 13, 2025 14:33
@Nodonisko Nodonisko requested review from a team, tomasklim and matejkriz as code owners January 13, 2025 14:33
@Nodonisko Nodonisko force-pushed the feat/update-firmware-alert branch from 215e8f9 to b512d83 Compare January 13, 2025 14:33
@Nodonisko Nodonisko changed the title feat(mobile): update FW alert on homescreen feat(mobile): update FW alert on Home + remote feature flag Jan 13, 2025
@Nodonisko Nodonisko force-pushed the feat/update-firmware-alert branch 2 times, most recently from 5305247 to 6472290 Compare January 14, 2025 13:34
@matejkriz matejkriz added the mobile Suite Lite issues and PRs label Jan 14, 2025
matejkriz
matejkriz reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the wrong condition in useIsFirmwareUpdateFeatureEnabled.tsx
it works and looks good, including possibility to disable via message-system. It's nice that it's animated.

@Nodonisko Nodonisko force-pushed the feat/update-firmware-alert branch from 6472290 to 836f976 Compare January 15, 2025 13:43
@Nodonisko
Copy link
Contributor Author

After discussion with @matejkriz I removed local feature flag so we have only remote one. Just to be sure I retested remote one once more.

matejkriz
matejkriz approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks good, but still we should consider hiding the promotion banner from the dashboard at least for the first release to stay on a safer side.

@Nodonisko Nodonisko force-pushed the feat/update-firmware-alert branch 2 times, most recently from 1104561 to 8aee1e5 Compare January 15, 2025 14:46
@Nodonisko Nodonisko force-pushed the feat/update-firmware-alert branch from 8aee1e5 to 875565e Compare January 17, 2025 10:17
@Nodonisko Nodonisko merged commit 059e89b into develop Jan 17, 2025
80 checks passed
@Nodonisko Nodonisko deleted the feat/update-firmware-alert branch January 17, 2025 11:06
@STew790
Copy link
Contributor

STew790 commented Jan 20, 2025

QA OK
No local ff present. Alert on Home present when FW can be updated.
image

Info
21.5.2 59e12ce

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanascz yanascz yanascz left review comments

@matejkriz matejkriz matejkriz approved these changes

@tomasklim tomasklim Awaiting requested review from tomasklim tomasklim is a code owner

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nodonisko @STew790 @matejkriz @yanascz