panic unwinding #232
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
2 errors and 14 warnings
no method named `response_body` found for enum `std::option::Option` in the current scope:
trillium/src/conn.rs#L232
error[E0599]: no method named `response_body` found for enum `std::option::Option` in the current scope
--> trillium/src/conn.rs:232:20
|
232 | self.inner.response_body()
| ^^^^^^^^^^^^^ method not found in `Option<Conn<BoxedTransport>>`
|
note: the method `response_body` exists on the type `trillium_http::Conn<trillium_http::transport::BoxedTransport>`
--> /home/runner/work/trillium/trillium/http/src/conn.rs:333:5
|
333 | pub fn response_body(&self) -> Option<&Body> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: use the `?` operator to extract the `trillium_http::Conn<trillium_http::transport::BoxedTransport>` value, propagating an `Option::None` value to the caller
|
232 | self.inner?.response_body()
| +
|
coverage
Process completed with exit code 1.
|
item in documentation is missing backticks:
http/src/transport/boxed_transport.rs#L54
warning: item in documentation is missing backticks
--> http/src/transport/boxed_transport.rs:54:18
|
54 | Create a new BoxedTransport from some Transport.
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
54 | Create a new `BoxedTransport` from some Transport.
| ~~~~~~~~~~~~~~~~
|
`IntoIterator` implemented for a reference type without an `iter` method:
http/src/headers/header_values.rs#L61
warning: `IntoIterator` implemented for a reference type without an `iter` method
--> http/src/headers/header_values.rs:61:1
|
61 | / impl<'a> IntoIterator for &'a HeaderValues {
62 | | type Item = &'a HeaderValue;
63 | |
64 | | type IntoIter = std::slice::Iter<'a, HeaderValue>;
... |
68 | | }
69 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_without_iter
= note: `#[warn(clippy::into_iter_without_iter)]` implied by `#[warn(clippy::pedantic)]`
help: consider implementing `iter`
|
61 +
62 + impl HeaderValues {
63 + fn iter(&self) -> std::slice::Iter<'a, HeaderValue> {
64 + <&Self as IntoIterator>::into_iter(self)
65 + }
66 + }
|
|
matching over `()` is more explicit:
http/src/headers/header_name.rs#L93
warning: matching over `()` is more explicit
--> http/src/headers/header_name.rs:93:21
|
93 | Err(_) => UnknownHeader(UnknownHeaderName(SmartCow::Owned(SmartString::from(s)))),
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
|
docs for function which may panic missing `# Panics` section:
http/src/state_set.rs#L75
warning: docs for function which may panic missing `# Panics` section
--> http/src/state_set.rs:75:5
|
75 | / pub fn get_or_insert_with<F, T>(&mut self, default: F) -> &mut T
76 | | where
77 | | F: FnOnce() -> T,
78 | | T: Send + Sync + 'static,
| |_________________________________^
|
note: first possible panic found here
--> http/src/state_set.rs:80:9
|
80 | / self.0
81 | | .entry(TypeId::of::<T>())
82 | | .or_insert_with(|| Box::new(default()))
83 | | .downcast_mut()
84 | | .expect("StateSet maintains the invariant the value associated with a given TypeId is always the type associated with that TypeId.")
| |________________________________________________________________________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
docs for function which may panic missing `# Panics` section:
http/src/state_set.rs#L65
warning: docs for function which may panic missing `# Panics` section
--> http/src/state_set.rs:65:5
|
65 | pub fn get_or_insert<T: Send + Sync + 'static>(&mut self, default: T) -> &mut T {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> http/src/state_set.rs:66:9
|
66 | / self.0
67 | | .entry(TypeId::of::<T>())
68 | | .or_insert_with(|| Box::new(default))
69 | | .downcast_mut()
70 | | .expect("StateSet maintains the invariant the value associated with a given TypeId is always the type associated with that TypeId.")
| |________________________________________________________________________________________________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|
manual `Debug` impl does not include all fields:
http/src/upgrade.rs#L99
warning: manual `Debug` impl does not include all fields
--> http/src/upgrade.rs:99:1
|
99 | / impl<Transport> Debug for Upgrade<Transport> {
100 | | fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
101 | | f.debug_struct(&format!("Upgrade<{}>", std::any::type_name::<Transport>()))
102 | | .field("request_headers", &self.request_headers)
... |
110 | | }
111 | | }
| |_^
|
note: this field is unused
--> http/src/upgrade.rs:32:5
|
32 | pub state: StateSet,
| ^^^^^^^^^^^^^^^^^^^
note: this field is unused
--> http/src/upgrade.rs:35:5
|
35 | pub transport: Transport,
| ^^^^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
--> http/src/upgrade.rs:43:5
|
43 | pub stopper: Stopper,
| ^^^^^^^^^^^^^^^^^^^^
= help: consider including all fields in this `Debug` impl
= help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
= note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`
|
matching over `()` is more explicit:
http/src/synthetic.rs#L93
warning: matching over `()` is more explicit
--> http/src/synthetic.rs:93:13
|
93 | fn from(_: ()) -> Self {
| ^ help: use `()` instead of `_`: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
= note: `#[warn(clippy::ignored_unit_patterns)]` implied by `#[warn(clippy::pedantic)]`
|
it is more concise to loop over references to containers instead of using explicit iteration methods:
http/src/conn.rs#L810
warning: it is more concise to loop over references to containers instead of using explicit iteration methods
--> http/src/conn.rs:810:33
|
810 | for (header, values) in self.response_headers.iter() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&self.response_headers`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop
= note: `#[warn(clippy::explicit_iter_loop)]` implied by `#[warn(clippy::pedantic)]`
|
item in documentation is missing backticks:
http/src/conn.rs#L637
warning: item in documentation is missing backticks
--> http/src/conn.rs:637:22
|
637 | processing in an after_send hook, please open an issue. This hook
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
637 | processing in an `after_send` hook, please open an issue. This hook
| ~~~~~~~~~~~~
|
item in documentation is missing backticks:
http/src/conn.rs#L435
warning: item in documentation is missing backticks
--> http/src/conn.rs:435:5
|
435 | ReceivedBody provides an interface to read body content
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
435 | `ReceivedBody` provides an interface to read body content
| ~~~~~~~~~~~~~~
|
item in documentation is missing backticks:
http/src/conn.rs#L433
warning: item in documentation is missing backticks
--> http/src/conn.rs:433:16
|
433 | returns a [ReceivedBody] that references this conn. the conn
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
433 | returns a [`ReceivedBody`] that references this conn. the conn
| ~~~~~~~~~~~~~~
|
item in documentation is missing backticks:
http/src/conn.rs#L417
warning: item in documentation is missing backticks
--> http/src/conn.rs:417:18
|
417 | returns the [encoding_rs::Encoding] for this response, as
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
417 | returns the [`encoding_rs::Encoding`] for this response, as
| ~~~~~~~~~~~~~~~~~~~~~~~
|
item in documentation is missing backticks:
http/src/conn.rs#L401
warning: item in documentation is missing backticks
--> http/src/conn.rs:401:18
|
401 | returns the [encoding_rs::Encoding] for this request, as
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
--> http/src/lib.rs:10:23
|
10 | #![warn(missing_docs, clippy::pedantic, clippy::perf, clippy::cargo)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
|
401 | returns the [`encoding_rs::Encoding`] for this request, as
| ~~~~~~~~~~~~~~~~~~~~~~~
|
the borrowed expression implements the required traits:
http/src/conn.rs#L394
warning: the borrowed expression implements the required traits
--> http/src/conn.rs:394:13
|
394 | &mut self.request_body_state,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.request_body_state`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|