Add test for renameTable in Faker connector #24599
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Show resolved
Hide resolved
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sthandassery
force-pushed
the
unit-test-faker-rename-table
branch
from
968ea30 to
f5c25ca
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@nineinchnick can you take another look at this with those additional assertions? |
| @Test | ||
| void testRenameTable() | ||
| { | ||
| assertUpdate("CREATE TABLE faker.default.original_table (id INTEGER, name VARCHAR)"); |
There was a problem hiding this comment.
faker.default is the default catalog and schema name in this test class. No need to repeat that. Please remove it.
| // should not allow renaming to an already existing table. | ||
| assertQueryFails("ALTER TABLE faker.default.renamed_table RENAME TO faker.default.renamed_table", "line 1:1: Target table 'faker.default.renamed_table' already exists"); | ||
| assertUpdate("DROP TABLE faker.default.renamed_table"); | ||
| } |
There was a problem hiding this comment.
Please add another test (testRenameTableAcrossSchema) renaming it to a different schema.
Description
Adding unit test coverage for renameTable method in Faker connector.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.