Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for renameTable in Faker connector #24599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Open

Add test for renameTable in Faker connector #24599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f2e826
Add test for Faker connector renameTable
sthandassery Dec 30, 2024
f5c25ca
fixup! Add test for Faker connector renameTable
sthandassery Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,4 +402,16 @@ String columnSchema()
return "%s %s NOT NULL%s".formatted(name, type, propertiesSchema.isEmpty() ? "" : " WITH (%s)".formatted(propertiesSchema));
}
}

@Test
void testRenameTable()
{
assertUpdate("CREATE TABLE faker.default.original_table (id INTEGER, name VARCHAR)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faker.default is the default catalog and schema name in this test class. No need to repeat that. Please remove it.

assertUpdate("ALTER TABLE faker.default.original_table RENAME TO faker.default.renamed_table");
sthandassery marked this conversation as resolved.
Show resolved Hide resolved
// original_table should not exist anymore after renaming.
assertQueryFails("DESC faker.default.original_table", "line 1:1: Table 'faker.default.original_table' does not exist");
// should not allow renaming to an already existing table.
assertQueryFails("ALTER TABLE faker.default.renamed_table RENAME TO faker.default.renamed_table", "line 1:1: Target table 'faker.default.renamed_table' already exists");
assertUpdate("DROP TABLE faker.default.renamed_table");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add another test (testRenameTableAcrossSchema) renaming it to a different schema.

}
Loading