-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKEND] Update llvm to llvm/llvm-project@f142f8afe2 #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains the two commit we want to have for AMD backend: * llvm/llvm-project#102038 * llvm/llvm-project#104598
ThomasRaoux
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
cc @karupayun and @chsigg and @gflegar FYI |
antiagainst
added a commit
to antiagainst/triton
that referenced
this pull request
Aug 31, 2024
…-lang#4619)" This reverts commit 884c0ad because it triggers the following failure in certain kernels: llvm/lib/CodeGen/LiveVariables.cpp:159: void llvm::LiveVariables::HandleVirtRegUse (llvm::Register, llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion `MRI->getVRegDef(Reg) && "Register use before def!"' failed.
ThomasRaoux
pushed a commit
that referenced
this pull request
Aug 31, 2024
#4624) This reverts commit 884c0ad because it triggers the following failure in certain kernels: llvm/lib/CodeGen/LiveVariables.cpp:159: void llvm::LiveVariables::HandleVirtRegUse (llvm::Register, llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion `MRI->getVRegDef(Reg) && "Register use before def!"' failed.
antiagainst
added a commit
to antiagainst/triton
that referenced
this pull request
Aug 31, 2024
This contains the two commit we want to have for AMD backend: * llvm/llvm-project#102869 * llvm/llvm-project#104598 This needs to update `visitOperation` signature following llvm/llvm-project@15e915a44f Also added `mlir::LLVM::registerInlinerInterface` to address LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`) that was promised by dialect 'llvm' but never implemented.
antiagainst
pushed a commit
that referenced
this pull request
Sep 6, 2024
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
This contains the two commit we want to have for AMD backend: * llvm/llvm-project#102869 * llvm/llvm-project#104598 This needs to update `visitOperation` signature following llvm/llvm-project@15e915a44f Also added `mlir::LLVM::registerInlinerInterface` to address LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`) that was promised by dialect 'llvm' but never implemented.
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
…-lang#4619)" (triton-lang#4624) This reverts commit 884c0ad because it triggers the following failure in certain kernels: llvm/lib/CodeGen/LiveVariables.cpp:159: void llvm::LiveVariables::HandleVirtRegUse (llvm::Register, llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion `MRI->getVRegDef(Reg) && "Register use before def!"' failed.
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
…triton-lang#4176)" (triton-lang#4631) Turn back aggressive strategy by default to enable block merging given now we have upstream fixes for it brought in: triton-lang#4619. This reverts commit cf2ad02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the two commit we want to have for AMD backend:
This needs to update
visitOperation
signature followingllvm/llvm-project@15e915a44f
Also added
mlir::LLVM::registerInlinerInterface
to addressLLVM ERROR: checking for an interface (
mlir::DialectInlinerInterface
)that was promised by dialect 'llvm' but never implemented.