Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Update llvm to llvm/llvm-project@f142f8afe2 #4619

Merged
merged 5 commits into from
Aug 31, 2024

Conversation

antiagainst
Copy link
Collaborator

@antiagainst antiagainst commented Aug 30, 2024

This contains the two commit we want to have for AMD backend:

This needs to update visitOperation signature following
llvm/llvm-project@15e915a44f

Also added mlir::LLVM::registerInlinerInterface to address

LLVM ERROR: checking for an interface (mlir::DialectInlinerInterface)
that was promised by dialect 'llvm' but never implemented.

This contains the two commit we want to have for AMD backend:
* llvm/llvm-project#102038
* llvm/llvm-project#104598
@antiagainst antiagainst requested a review from ptillet as a code owner August 30, 2024 19:10
@antiagainst antiagainst requested a review from Jokeren as a code owner August 31, 2024 00:52
@antiagainst antiagainst enabled auto-merge (squash) August 31, 2024 06:01
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@antiagainst antiagainst merged commit 884c0ad into triton-lang:main Aug 31, 2024
7 checks passed
@antiagainst antiagainst deleted the update-llvm branch August 31, 2024 06:22
@antiagainst
Copy link
Collaborator Author

cc @karupayun and @chsigg and @gflegar FYI

antiagainst added a commit to antiagainst/triton that referenced this pull request Aug 31, 2024
…-lang#4619)"

This reverts commit 884c0ad because
it triggers the following failure in certain kernels:

llvm/lib/CodeGen/LiveVariables.cpp:159: void llvm::LiveVariables::HandleVirtRegUse
(llvm::Register, llvm::MachineBasicBlock *, llvm::MachineInstr &):
Assertion `MRI->getVRegDef(Reg) && "Register use before def!"' failed.
ThomasRaoux pushed a commit that referenced this pull request Aug 31, 2024
#4624)

This reverts commit 884c0ad because it
triggers the following failure in certain kernels:

llvm/lib/CodeGen/LiveVariables.cpp:159: void
llvm::LiveVariables::HandleVirtRegUse (llvm::Register,
llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion
`MRI->getVRegDef(Reg) && "Register use before def!"' failed.
antiagainst added a commit to antiagainst/triton that referenced this pull request Aug 31, 2024
This contains the two commit we want to have for AMD backend:
* llvm/llvm-project#102869
* llvm/llvm-project#104598

This needs to update `visitOperation` signature following
llvm/llvm-project@15e915a44f

Also added `mlir::LLVM::registerInlinerInterface` to address

LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`)
that was promised by dialect 'llvm' but never implemented.
antiagainst pushed a commit that referenced this pull request Sep 6, 2024
…#4176)" (#4631)

Turn back aggressive strategy by default to enable block merging
given now we have upstream fixes for it brought in:
#4619.

This reverts commit cf2ad02.
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
This contains the two commit we want to have for AMD backend:
* llvm/llvm-project#102869
* llvm/llvm-project#104598

This needs to update `visitOperation` signature following
llvm/llvm-project@15e915a44f

Also added `mlir::LLVM::registerInlinerInterface` to address

LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`)
that was promised by dialect 'llvm' but never implemented.
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
…-lang#4619)" (triton-lang#4624)

This reverts commit 884c0ad because it
triggers the following failure in certain kernels:

llvm/lib/CodeGen/LiveVariables.cpp:159: void
llvm::LiveVariables::HandleVirtRegUse (llvm::Register,
llvm::MachineBasicBlock *, llvm::MachineInstr &): Assertion
`MRI->getVRegDef(Reg) && "Register use before def!"' failed.
bertmaher pushed a commit to bertmaher/triton that referenced this pull request Dec 10, 2024
…triton-lang#4176)" (triton-lang#4631)

Turn back aggressive strategy by default to enable block merging
given now we have upstream fixes for it brought in:
triton-lang#4619.

This reverts commit cf2ad02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants