Revert "[AMD] Disable block merging to avoid block argument explosion (#4176)" #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joviliast I used to need this for some kernels that have compilation hanging issues. Did you check if the compilation hanging issues is gone with this PR? |
|
This PR causes compile time regression for some cases. I did not catch a dead hang, but some cases slow down in 10 times, which quite critical. |
joviliast
changed the title
cc+ @giuseros |
joviliast
force-pushed
the
enable-block-merging
branch
from
1dc3f63 to
24bfa51
Compare
joviliast
changed the title
…triton-lang#4176)" This reverts commit cf2ad02 and enables aggresive strategy to enable block merging.
Regression was fixed by #4655. |
antiagainst
approved these changes
Sep 6, 2024
zhanglx13
approved these changes
Sep 6, 2024
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
…triton-lang#4176)" (triton-lang#4631) Turn back aggressive strategy by default to enable block merging given now we have upstream fixes for it brought in: triton-lang#4619. This reverts commit cf2ad02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn back aggressive strategy by default to enable block merging
given now we have upstream fixes for it brought in:
#4619.
This reverts commit cf2ad02.