Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Update llvm to llvm/llvm-project@fa57c7a6a5f594a9e3ae2dbe35… #5064

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

htyu
Copy link
Collaborator

@htyu htyu commented Nov 5, 2024

Bumping llvm to include a loop unroller fix: llvm/llvm-project#114573. This is needed for subsequent loop unroller upstreaming work.

@htyu htyu requested a review from ThomasRaoux November 5, 2024 00:23
@htyu htyu requested a review from ptillet as a code owner November 5, 2024 00:23
@ThomasRaoux
Copy link
Collaborator

you need to go to llvm-head first to get the llvm build to kick off

@htyu
Copy link
Collaborator Author

htyu commented Nov 5, 2024

you need to go to llvm-head first to get the llvm build to kick off

I already pushed the same pin update to llvm-head. How long does it usually take for a llvm build to finish?

@ThomasRaoux
Copy link
Collaborator

you need to go to llvm-head first to get the llvm build to kick off

I already pushed the same pin update to llvm-head. How long does it usually take for a llvm build to finish?

ah missed, that. it take maybe 1-2 hours I believe

@htyu
Copy link
Collaborator Author

htyu commented Nov 5, 2024

you need to go to llvm-head first to get the llvm build to kick off

I already pushed the same pin update to llvm-head. How long does it usually take for a llvm build to finish?

ah missed, that. it take maybe 1-2 hours I believe

I actually accidentally pushed that in without going through a PR.

@htyu
Copy link
Collaborator Author

htyu commented Nov 5, 2024

Looks like the llvm build is still not ready. Could that because I didn't land the llvm-head change via a PR?

@ThomasRaoux
Copy link
Collaborator

Looks like the llvm build is still not ready. Could that because I didn't land the llvm-head change via a PR?

looks like it worked:
https://github.com/triton-lang/triton/actions/runs/11675045023

@htyu
Copy link
Collaborator Author

htyu commented Nov 5, 2024

registerOptimizerLastEPCallback now takes extra parameter ThinOrFullLTOPhase. Fixed test code correspondingly.

@htyu htyu merged commit 3c296ab into triton-lang:main Nov 5, 2024
7 checks passed
@htyu htyu deleted the hoy/pin branch November 5, 2024 07:09
Luosuu pushed a commit to Luosuu/triton that referenced this pull request Nov 13, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.
guacamoleo pushed a commit to guacamoleo/triton that referenced this pull request Nov 14, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.
jataylo pushed a commit to jataylo/triton that referenced this pull request Dec 4, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.

(cherry picked from commit 3c296ab)
jataylo pushed a commit to jataylo/triton that referenced this pull request Dec 5, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.

(cherry picked from commit 3c296ab)
jataylo pushed a commit to jataylo/triton that referenced this pull request Dec 6, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.

(cherry picked from commit 3c296ab)
jataylo added a commit to jataylo/triton that referenced this pull request Dec 11, 2024
jataylo pushed a commit to jataylo/triton that referenced this pull request Dec 11, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.

(cherry picked from commit 3c296ab)
jataylo pushed a commit to jataylo/triton that referenced this pull request Dec 12, 2024
triton-lang#5064)

Bumping llvm to include a loop unroller fix:
llvm/llvm-project#114573. This is needed for
subsequent loop unroller upstreaming work.

(cherry picked from commit 3c296ab)
antiagainst added a commit that referenced this pull request Dec 13, 2024
This PR brings in required LLVM bumps and additional targets for gfx950
support.
- #5040
- #5064
- #5180
- #5242
- #5392

Note this PR reverts the last two PRs to only focus on the LLVM upgrade
- #5347 
- #5191

---------

Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
jataylo added a commit to jataylo/triton that referenced this pull request Dec 18, 2024
This PR brings in required LLVM bumps and additional targets for gfx950
support.
- triton-lang#5040
- triton-lang#5064
- triton-lang#5180
- triton-lang#5242
- triton-lang#5392

Note this PR reverts the last two PRs to only focus on the LLVM upgrade
- triton-lang#5347
- triton-lang#5191

---------

Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
(cherry picked from commit f11c5ba)
jataylo added a commit to jataylo/triton that referenced this pull request Dec 18, 2024
This PR brings in required LLVM bumps and additional targets for gfx950
support.
- triton-lang#5040
- triton-lang#5064
- triton-lang#5180
- triton-lang#5242
- triton-lang#5392

Note this PR reverts the last two PRs to only focus on the LLVM upgrade
- triton-lang#5347
- triton-lang#5191

---------

Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
(cherry picked from commit f11c5ba)
atalman pushed a commit that referenced this pull request Dec 19, 2024
This PR brings in required LLVM bumps and additional targets for gfx950
support.
- #5040
- #5064
- #5180
- #5242
- #5392

Reverts:
- #5347 
- #5191
bertmaher pushed a commit that referenced this pull request Dec 19, 2024
This PR brings in required LLVM bumps and additional targets for gfx950
support.
- #5040
- #5064
- #5180
- #5242
- #5392

Note this PR reverts the last two PRs to only focus on the LLVM upgrade
- #5347 
- #5191

---------

Co-authored-by: peterbell10 <[email protected]>
Co-authored-by: Hongtao Yu <[email protected]>
Co-authored-by: Lei Zhang <[email protected]>
Co-authored-by: Jungwook Park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants