Blacklight 8 #495
Merged
Blacklight 8 #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the item page
Add tools to the index page
Update skip links to use BL component
Update search result layout for BL 8
Remove workarounds for ruby 2.x, bootstrap 4 and rails versions below 7
Create helper method for trln solr doc url
- Update the customized copy of BL core base layout; omit its references to Importmap & Propshaft - Run the BL generator with --skip-assets to bypass the Importmap setup - Run the BL assets generator for Sprockets (blacklight:assets:sprockets) - Add & require jQuery as a dependency (no longer included via Bootstrap 5) - Add more info output to steps in the generator to clarify what is happening
Get basic Javascript working in BL8 using Sprockets. Closes TD-1355.
Blacklight 8 / Bootstrap 5 updates
Get autocomplete working again
…TD-1402 & TD-1410. - Drops the trln-chosen-rails forked gem altogether; instead just vendors a few files within trln_argon - Uses the transpiled assets from the chosen_v1.8.7.zip build at https://github.com/harvesthq/chosen/releases/tag/v1.8.7 - These assets were transpiled directly by chosen-rails via its `grunt build` task
…scriptive "cover image" text. Fixes TD-1406.
Fix keyboard nav & icons for Chosen fields in Advanced Search. Fixes …
- Removes label element, not appropriate for buttons so WAVE flags as violation - Reduces CSS complexity by using flexbox & BS5 styles - Improves keyboard accessibility; focus ring now surrounds focused button - Makes the element look more like a connected toggle, esp. when vertically stacked - Removes unused cruft - Restyles so the present scope is gray and the scope you can toggle to looks like a link (was backward before)
- Also updates existing customizations to use BL8 code & conventions.
- fixes WAVE warning: adjacent links go to same URL - there was an unwanted duplicate navbar-brand link; this commit consolidates.
…ge. Fixes TD-1396.
Use empty alt tags for thumbnail images rather than repetitive non-de…
Fix color accessibility in selected constraints; fixes TD-1404.
Refactors trln/local toggle for accessibility. Fixes TD-1403.
Followup bugfix to remove skip to search on *only* advanced search pa…
Fix masthead a11y warning; remove duplicate link. Fixes TD-1399.
Bugfix for chosen.css - was not compiling in production env
Bugfix for share bookmarks URLs; permit doc_ids parameter. Fixes TD-1…
Permit id & debug parameters to be used. Fixes TD-1316.
- subclass the BL core SkipLinkComponent and configure trln_argon to use ours - note legacy BS4 .sr-only is problematic due to css in font-awesome-rails gem - refactors fix from #448 so it uses a subclassed component
- also corrects a related typo that was breaking blank search functionality per TD-48.
Bugfix for checking Available Online from homepage. Fixes TD-1413.
Fix skip link display during keyboard navigation. Fixes TD-1412.
…lowup for TD-1379. - Deprecation config became available in dartsass-sprockets 3.2.0 (Jan 2025)
… beta. Completes TD-1382.
Quiet Sass deprecation warnings from dependencies like Bootstrap. Fol…
Use stable 9.x release of blacklight_range_limit plugin, no longer in…
seanaery
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Blacklight from version 7 to version 8. A wiki page with more upgrade notes is available: Blacklight 8 Upgrade Notes. All changes are summarized in the v3.0.0 release notes.