Fix RuboCop

Small code adjustments were added because of the newer version 1.70.0 of RuboCop.

Upgrade to Blacklight 8

There is a wiki page with more upgrade notes available here: Blacklight 8 Upgrade Notes.

Major Changes in This Release

This release includes key upgrades and changes:

• Blacklight updated from version 7 to 8 for better performance and functionality.
• Bootstrap updated from version 4 to 5 for improved accessibility and styling.
• blacklight_range_limit plugin updated from version 7 to 9 for compatibility with Blacklight 8.
• Transitioned from sassc-rails to dartsass-sprockets to fix SASS compatibility issues.
• Removed the forked chosen-rails gem.

HTML/CSS

• Skip Link Fix

  • Fixed skip link display during keyboard navigation.
  • Subclassed the Blacklight core SkipLinkComponent and configured trln_argon to use the customized version.
  • Addressed issues with legacy BS4 .sr-only classes that conflicted with CSS in the font-awesome-rails gem.
  • Related bug fix: Removed "skip to search" link on the Advanced Search page.
  • (TD-1412, TD-1396)

• Chosen CSS Bug Fix

  • Fixed an issue where chosen.css was not compiling in the production environment.
  • (TD-1402)

• Facet Styling

  • Removed old facet style hacks.
  • Ensured checkbox facets (e.g., Available Online) use flexbox for consistency with other facets.
  • (TD-1377, TD-1368)

• CSS for Advanced Search Publication Year Fields

  • Adjusted the layout of Advanced Search Publication Year input fields for better alignment and compactness.
  • (TD-1383)

• Layout and UI Fixes

  • Fixed layout of search thumbnails to improve visual presentation.
  • (TD-1345)

JavaScript

• Advanced Search JS Fixes

  • Refined JS logic for Advanced Search page to improve functionality.
  • Fixed skip link functionality and updated aria labels for various elements.
  • (TD-1395, TD-1401, TD-1396)

• Chosen Plugin Update

  • Fixed keyboard navigation and icon issues for Chosen fields in Advanced Search.
  • Removed the trln-chosen-rails fork and vendor files directly from trln_argon.
  • (TD-1402)

Accessibility

• Skip Link Accessibility

  • Fixed display and usability of skip link during keyboard navigation, improving the overall user experience.
  • (TD-1412)

• Advanced Search Accessibility

  • Addressed various WAVE-flagged accessibility issues in the Advanced Search page.
  • Fixed aria labels for sort results and selector elements.
  • Removed the "skip to search" link on Advanced Search page for improved clarity.
  • (TD-1395, TD-1397, TD-1400, TD-1396, TD-1391)

• Orphaned Form Labels Fix

  • Refactored the trln/local toggle for accessibility.
  • Removed inappropriate label elements and improved keyboard navigation and focus ring behavior.
  • Simplified the CSS using flexbox and updated the design.
  • (TD-1403)

• Color Accessibility

  • Improved color contrast for selected constraints to meet accessibility standards.
  • (TD-1404)

Ruby

• Ruby 3.x Compatibility

  • Updated the Docker configuration to support Ruby 3.1.6 by default.
  • Pin Ruby version for consistency in CI and Docker environments.
  • Fixed compatibility issues with various gems (e.g., dartsass-sprockets) for Ruby 3.0 and 3.1.
  • (TD-1358)

• SASS Deprecation Fixes

  • Replaced deprecated lighten() and darken() functions with Bootstrap 5's tint-color() and shade-color().
  • Reduced DartSass-Sprockets deprecation warnings in production.
  • (TD-1379)

• Blacklight Range Limit Plugin Update

  • Upgraded the blacklight_range_limit plugin to version 9.0.0 to work with Blacklight 8.
  • (TD-1382)

Other Updates

• Bookmarking & Caching Fixes

  • Fixed caching for homepage Solr query and advanced search facet queries.
  • Addressed issues with bookmark actions and replaced obsolete references to @document_list.
  • (TD-1393, TD-1390)

• Search UI Improvements

  • Addressed UI issues with missing titles and layout issues on the main search page.
  • (TD-1340)

• RSS Feed Fixes

  • Fixed issues with RSS feeds and the reference to @document_list.
  • (TD-1392)

• Miscellaneous Bug Fixes

  • Fixed display issues with the range limit submit button.
  • Added missing icons to tools on the item page.
  • Fixed an issue where the 'Available Online' checkbox facet did not return any results when checked from the homepage.
  • Fixed performing a blank search.
  • (TD-1349, TD-1413)

v2.4.5: Search Form Accessibility

Addresses two search form accessibility issues (TD-1381).

• The autosuggest overlay in the main search box was resulting in a missing form label
• The Advanced Search “chosen” facet labels were missing

v2.4.4: Holdings-level Availability Status

Display holdings-level availability status on item show pages (if present). Closes TD-1336.

Changes

• This change especially accommodates Duke records (post-Alma migration) where availability status is encoded at the holdings instead of item level
• Ensures horizontal alignment of holdings-level & item-level availability text
• Lets narrow location header extend to full width if it has no holdings-level availability status
• Extends the existing conditional item status styling/color rules to apply to holdings status
• Also suppresses display of the "status" label if the value is blank
• Adds an overridable items_section_location_status partial as a local hook to override if desired
• Adds two new helper methods, display_item_availability? & display_holdings_availability?, which can be overridden locally if desired

Update Notes

• This update should result in no perceptible change to the display of item availability for resources held by NCSU, UNC, or NCCU (i.e., where availability status is always present at the item level). At present, this will only affect the presentation of Duke's holdings on item views.
• If you have customized local copies of any affected partials, you will likely need to replicate the changes. See especially: _items_section.html.erb, _items_section_item.html.erb, & _items_section_location.html.erb.
• If further customization is desired locally, this version has added three new seams that can be overridden: the display_item_availability? & display_holdings_availability? helper methods, and the _items_section_location_status.html.erb partial.

Enhancements, Bug Fixes, and Compatibility Updates for Rails 7.2 Migration

Enhancements:

• Updated the convert_to_bibtex_format method to default to 'book' if the type is not specified. Example: https://discovery.trln.org/trln/NCSU1528161.

Bug Fixes:

• Resolved the SocketError: getaddrinfo: nodename nor servname provided to enhance stability and prevent network-related errors during execution.
• Fixed test cases for hathi_links_grouped_by_oclc_number and ia_ids_grouped_by_class, ensuring all tests pass successfully.

Updates:

• Updated to use 'rspec-rails', '~> 6' to align with recent changes and improve compatibility with newer Rails versions.
• Changed config.fixture_path to config.fixture_paths as part of the migration to Rails 7.2. A comment was added to provide clarification on this change.

Blacklight 8: Deprecation warnings

Fixes:

• Fixed deprecation warnings for Blacklight::ConfigurationHelperBehavior in _search_form.html.erb.
• Fixed deprecation warnings for Blacklight::RenderPartialsHelperBehavior in _search_results.html.erb.
• Fixed deprecation warning for render_hash_as_hidden_fields by replacing it with Blacklight::HiddenSearchStateComponent.

Blacklight 8 DEPRECATION WARNING: Transition to Blacklight::DocumentPresenter#html_title

This release fixes the DEPRECATION WARNING: document_show_html_title is deprecated. (Use Blacklight::DocumentPresenter#html_title instead).

Implement citeproc for citation generation

By default, the following citation formats will be displayed:
'apa, modern-language-association, chicago-fullnote-bibliography, harvard-cite-them-right, turabian-fullnote-bibliography.'

If you need to change this list, add a variable to the local_env.yml file with your list of formats:
CITATION_FORMATS: 'apa, modern-language-association, chicago-fullnote-bibliography'

If you provide your own list, ensure you include appropriate headings for your citations in trln_argon.en.yml. Citation formats are sourced from the Citation Style Language (CSL) repository on GitHub: https://github.com/citation-style-language/styles.

Here is an examples:

Use main blacklight-hierarchy gem instead of TRLN's local fork.

This release resolves TD-1329.

• TRLN's enhancements are now in blacklight-hierarchy as of 6.3.0
• Adds ability for TRLN partners to customize expand/collapse SVG icon & color via CSS

Fix: 590 Notes Not Appearing

Merge pull request #423 from trln/TD-1329-remove-hierarchy-fork

Use main blacklight-hierarchy gem instead of TRLN's local fork. Resol…