Skip to content

v2.2.4 - Bugfix for dd metadata (TD-1264)
Compare
Choose a tag to compare
@seanaery seanaery released this 22 Feb 21:10
· 235 commits to main since this release
v2.2.4
8c5c544
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

This release fixes bug TD-1264, in which TRLN Argon began rendering unwanted and invalid/inaccessible <dd> elements in all the various places where metadata values are displayed, due to upstream changes in Blacklight and ViewComponent. See PR with screenshots.

This change leans into the <dd> elements by rendering the accompanying <dl> & <dt> to ensure the markup is valid and accessible.

Explanation

Blacklight 7.32.0, began requiring ViewComponent 2.66+ at which time it became impossible to short-circuit a metadata viewcomponent with arbitrary markup in a value slot when there is already a values slot. Note in Blacklight 8 the definition list markup can be changed when instantiating a metadata component, but it's not currently customizable in 7.x.

Upgrade Notes

You may need to revise some CSS if you have rules targeting the metadata values. E.g., if you have styles for:

.index-document-metadata ul li.index-metadata.creator_main_a { }
#show-sub-header ul li.index-metadata.creator_main_a { }

...the equivalents would be:

.index-document-metadata dl dd.creator_main_a { }
#show-sub-header dl dd.creator_main_a { }
Assets 2
Loading