Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Testing compile --list docker shouldn't rely on networking #5639

Open
cds-amal opened this issue Oct 23, 2022 · 0 comments
Open

Testing compile --list docker shouldn't rely on networking #5639

cds-amal opened this issue Oct 23, 2022 · 0 comments

Comments

@cds-amal
Copy link
Member

core/test/lib/commands/compile.js causes CI to fail, specifically for the --list docker which times out when querying Docker-hub. We should probably evaluate the tests' benefits and consider mocking away network calls as @haltman-at previously suggested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants