This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
update gh-actions to use node 16 #5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All action runs warn about node 12 deprecation and urge actions to migrate to node 16. See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
This test should be rewritten: #5639
cds-amal
force-pushed
the
gh/actions-bump
branch
from
390fb71 to
6da9f7f
Compare
cds-amal
commented
Oct 24, 2022
Comment on lines
+103
to
+105
| this.timeout( | ||
| 60000 * 2 // oh boy! | ||
| ); |
There was a problem hiding this comment.
2 minutes is an egregious limit for a test. OTOH, these tests shouldn't hit the network. I opened #5639 to capture that.
haltman-at
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR bumps our action dependencies to address the following warnings for the
buildandyarncheckjobs:Notes
compile --list dockershouldn't rely on networking #5639Documentation