This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Allow users to enable @truffle/db as a system of record for their Truffle projects #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e582dd2
to
de4a3b6
Compare
eggplantzzz
reviewed
Feb 24, 2021
const OS = require("os"); | ||
const serveCommand = require("./commands/serve"); | ||
|
||
const usage = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style of these; does it really match with the rest of the Truffle help messages? Maybe we should indent "Available sub-commands" and "serve \tStart..." a bit more...or we could list the subcommands like we list the options? So they are indented far in, what do you think?
So that networks and contract instances get saved in DB
Allow configuring host for `truffle db serve`
…-compile Ensure artifacts are saved with db info
…cts (do not add abstract contracts or interfaces
Hook up `truffle migrate` to @truffle/db
Co-authored-by: David Murdoch <[email protected]>
Co-authored-by: David Murdoch <[email protected]>
... so as to avoid manual element creation via function call
Co-authored-by: Heyse Li <[email protected]>
Force params in web3 request
Add initial @truffle/db-kit demo package
fainashalts
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drumroll please... LGTM!
It's in :) |
This was referenced Oct 17, 2022
This was referenced Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, adding
db: { enabled: true }
will turn on @truffle/db for use withtruffle compile
,truffle migrate
, etc.This only adds data to @truffle/db right now; nothing inside Truffle is currently configured to read from @truffle/db.