Internal update: clean dependencies #4149
Conversation
cds-amal
force-pushed
the
clean-dependency
branch
2 times, most recently
from
ff8c1d9 to
9fdcd75
Compare
cds-amal
force-pushed
the
clean-dependency
branch
from
9fdcd75 to
7359831
Compare
| @@ -26,7 +26,6 @@ | |||
| }, | |||
| "types": "dist/index.d.ts", | |||
| "dependencies": { | |||
| "@types/node": "^15.0.1", | |||
There was a problem hiding this comment.
This package's tsconfig references this. Make sure you can remove it there before saying it's not a dependency.
Although it probably should be a devDep.
There was a problem hiding this comment.
I'm not sure what the intention was here. According to the docs
If typeRoots is specified, only packages under typeRoots will be included.
This config implies that node is excluded because it wouldn't appear in typeRoots list of paths
"typeRoots": [
"./typings",
"../../**/node_modules/@types/debug"
],
"types": ["node"]
Have you used any tools to verify this behavior? It would be nice to have tests. tsd seems promising ¯_(ツ)_/¯
There was a problem hiding this comment.
Just try taking it out and see if it breaks
There was a problem hiding this comment.
Will people be trying to install this package into their projects and building with TS? :) This is the same kind of thing as what we were talking about earlier with hdwallet-provider, right? I don't know what the right answer is here by the way.
gnidan
dismissed
their stale review
Dismissing review so as not to impede things while I'm OOO
|
I like it! |
- crypto-js
app-module-path is used for testing, move it to dev dependency - [x] app-module-path
- `yarn remove @types/node` updated yarn.lock
- node-emoji
- `yarn remove any-promise bindings` - auto update yarn.lock
- `yarn remove node-fetch`
- `yarn remove web3`
- [x] mocha - [x] ts-node
- `yarn remove highlight.js`, updated yarn.lock
- `yarn remove supports-color`
- `yarn remove web3`
- `yarn remove redux-cli-logger web3-eth-abi`, updated yarn.lock
- `yarn remove @truffle/contracts-sources` - `yarn remove @truffle/preserve-fs` - `yarn remove @truffle/preserve-to-buckets` - `yarn remove @truffle/preserve-to-filecoin` - `yarn remove @truffle/preserve-to-ipfs` - `yarn remove app-module-path`
This reverts commit 4fb14e3.
This reverts commit f91f21f.
- @truffle/contract-sources - node-ipc
Explicitly specify definitions with `types`
cds-amal
force-pushed
the
clean-dependency
branch
from
c2b4e58 to
eebc7f9
Compare
This PR removes unused dependencies from project workspaces .