Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Internal update: clean dependencies #4149

Merged
merged 19 commits into from
Jul 24, 2021
Merged

Internal update: clean dependencies #4149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c224a43
contract-schema: remove unused dependency
cds-amal Jun 30, 2021
8b73f36
plugins: move app-module-path to devDependency
cds-amal Jun 29, 2021
ec2cd00
source-fetcher: remove unused dependency
cds-amal Jun 30, 2021
05ea7e9
reporters: remove unused dependency
cds-amal Jun 30, 2021
bf4639a
hdwallet-provider: remove unused dependencies
cds-amal Jun 30, 2021
ce3f5a6
preserve-to-filecoin: remove unused dependency
cds-amal Jun 30, 2021
5ee7b4e
require: remove unused dependency
cds-amal Jun 30, 2021
cbcd2cc
compile-common: move packages to devDependency
cds-amal Jun 29, 2021
46e7dc6
debug-utils: remove unused dependency
cds-amal Jun 30, 2021
88d5d2c
resolver: remove unused dependency
cds-amal Jun 30, 2021
b6f39d9
migrate: remove unused dependency
cds-amal Jun 30, 2021
13c368f
debugger: remove unused dependencies
cds-amal Jun 30, 2021
f91f21f
core: remove unused dependencies
cds-amal Jun 30, 2021
b19e21f
Revert "plugins: move app-module-path to devDependency"
cds-amal Jul 2, 2021
df0e18b
Revert "core: remove unused dependencies"
cds-amal Jul 22, 2021
c009a52
core: move app-module-path to devDeps
cds-amal Jul 22, 2021
68c4af0
core: remove unused deps
cds-amal Jul 22, 2021
d0d9a60
source-fetcher: add @types/node^15.0.1 as a devDep
cds-amal Jul 7, 2021
eebc7f9
source-fetcher: reorg how definitions are imported
cds-amal Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/compile-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
"@truffle/contract-schema": "^3.4.1",
"@types/fs-extra": "^8.1.0",
"@types/mocha": "^5.2.7",
"mocha": "8.0.1",
"ts-node": "^9.0.0",
"typescript": "^4.1.4"
},
"dependencies": {
Expand All @@ -29,9 +31,7 @@
"@truffle/expect": "^0.0.17",
"colors": "^1.4.0",
"debug": "^4.3.1",
"fs-extra": "^9.1.0",
"mocha": "8.0.1",
"ts-node": "^9.0.0"
"fs-extra": "^9.1.0"
},
"gitHead": "6b84be7849142588ef2e3224d8a9d7c2ceeb6e4a"
}
1 change: 0 additions & 1 deletion packages/contract-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"typings": "./typings/index.d.ts",
"dependencies": {
"ajv": "^6.10.0",
"crypto-js": "^3.1.9-1",
"debug": "^4.3.1"
},
"devDependencies": {
Expand Down
4 changes: 1 addition & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"@truffle/compile-solidity": "^5.3.12",
"@truffle/config": "^1.3.0",
"@truffle/contract": "^4.3.25",
"@truffle/contract-sources": "^0.1.12",
"@truffle/debug-utils": "^5.1.5",
"@truffle/debugger": "^9.1.6",
"@truffle/decoder": "^4.6.6",
Expand All @@ -49,7 +48,6 @@
"@truffle/resolver": "^7.0.19",
"@truffle/source-fetcher": "^0.5.2",
"@truffle/workflow-compile": "^3.2.20",
"app-module-path": "^2.2.0",
cds-amal marked this conversation as resolved.
Show resolved Hide resolved
"chai": "^4.2.0",
"colors": "^1.4.0",
"command-exists": "^1.2.8",
Expand All @@ -70,7 +68,6 @@
"js-interpreter": "2.2.0",
"mocha": "8.1.2",
"node-emoji": "^1.8.1",
"node-ipc": "^9.1.1",
"ora": "^3.4.0",
"original-require": "^1.0.1",
"sane": "^4.0.2",
Expand All @@ -86,6 +83,7 @@
},
"devDependencies": {
"@truffle/blockchain-utils": "^0.0.31",
"app-module-path": "^2.2.0",
"chai-as-promised": "^7.1.1",
"memorystream": "^0.3.1",
"sinon": "^9.0.2"
Expand Down
1 change: 0 additions & 1 deletion packages/debug-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"bn.js": "^5.1.3",
"chalk": "^2.4.2",
"debug": "^4.3.1",
"highlight.js": "^10.4.0",
cds-amal marked this conversation as resolved.
Show resolved Hide resolved
"highlightjs-solidity": "^1.2.0"
},
"devDependencies": {
Expand Down
1 change: 0 additions & 1 deletion packages/debugger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"lodash.sum": "^4.0.2",
"lodash.zipwith": "^4.2.0",
"redux": "^3.7.2",
"redux-cli-logger": "^2.0.1",
"redux-saga": "1.0.0",
"remote-redux-devtools": "^0.5.12",
"reselect-tree": "^1.3.4",
Expand Down
2 changes: 0 additions & 2 deletions packages/hdwallet-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
"types": "dist/index.d.ts",
"dependencies": {
"@trufflesuite/web3-provider-engine": "15.0.13-1",
"any-promise": "^1.3.0",
"bindings": "^1.5.0",
"ethereum-cryptography": "^0.1.3",
"ethereum-protocol": "^1.0.1",
"ethereumjs-common": "^1.5.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/migrate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"@truffle/reporters": "^2.0.1",
"@truffle/require": "^2.0.68",
"emittery": "^0.4.1",
"glob": "^7.1.6",
"web3": "1.4.0"
"glob": "^7.1.6"
cds-amal marked this conversation as resolved.
Show resolved Hide resolved
},
"devDependencies": {
"mocha": "8.1.2",
Expand Down
3 changes: 1 addition & 2 deletions packages/preserve-to-filecoin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"@truffle/preserve": "^0.2.3",
"cids": "^1.1.5",
"delay": "^5.0.0",
"filecoin.js": "^0.0.5-alpha",
"node-fetch": "^2.6.0"
"filecoin.js": "^0.0.5-alpha"
}
}
1 change: 0 additions & 1 deletion packages/reporters/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"prepare": "exit 0"
},
"dependencies": {
"node-emoji": "^1.8.1",
"ora": "^3.4.0",
"web3-utils": "1.4.0"
},
Expand Down
3 changes: 1 addition & 2 deletions packages/require/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
"@truffle/config": "^1.3.0",
"@truffle/expect": "^0.0.17",
"@truffle/interface-adapter": "^0.5.2",
"original-require": "^1.0.1",
"web3": "1.4.0"
"original-require": "^1.0.1"
},
"devDependencies": {
"mocha": "8.1.2"
Expand Down
3 changes: 1 addition & 2 deletions packages/resolver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"debug": "^4.3.1",
"detect-installed": "^2.0.4",
"get-installed-path": "^4.0.8",
"glob": "^7.1.6",
"supports-color": "^7.1.0"
"glob": "^7.1.6"
cds-amal marked this conversation as resolved.
Show resolved Hide resolved
},
"devDependencies": {
"@types/node": "12.12.21",
Expand Down
2 changes: 1 addition & 1 deletion packages/source-fetcher/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
},
"types": "dist/index.d.ts",
"dependencies": {
"@types/node": "^15.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package's tsconfig references this. Make sure you can remove it there before saying it's not a dependency.

Although it probably should be a devDep.

Copy link
Member Author

@cds-amal cds-amal Jul 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the intention was here. According to the docs

If typeRoots is specified, only packages under typeRoots will be included.

This config implies that node is excluded because it wouldn't appear in typeRoots list of paths

    "typeRoots": [
      "./typings",
      "../../**/node_modules/@types/debug"
    ],
    "types": ["node"]

Have you used any tools to verify this behavior? It would be nice to have tests. tsd seems promising ¯_(ツ)_/¯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just try taking it out and see if it breaks

Copy link
Contributor

@eggplantzzz eggplantzzz Jul 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will people be trying to install this package into their projects and building with TS? :) This is the same kind of thing as what we were talking about earlier with hdwallet-provider, right? I don't know what the right answer is here by the way.

"axios": "^0.21.1",
"debug": "^4.3.1",
"web3-utils": "1.4.0"
},
"devDependencies": {
"@types/debug": "^4.1.5",
"@types/node": "^15.0.1",
"typescript": "^4.1.4"
},
"keywords": [
Expand Down
9 changes: 2 additions & 7 deletions packages/source-fetcher/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,10 @@
"paths": {
},
"rootDir": "lib",
"typeRoots": [
"./typings",
"../../**/node_modules/@types/debug"
],
"types": ["node"]
"types": ["debug", "node"]
},
"include": [
"./lib/**/*.ts",
"./typings/**/*.d.ts"
"./lib/**/*.ts"
]

}
22 changes: 5 additions & 17 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4431,9 +4431,9 @@
integrity sha512-dBPaxocOK6UVyvhbnpFIj2W+S+1cBTkHQbFQfeeJhoKFbzYcVUGHvddeWPSucKATb3F0+pgDq0i6ghEaZjsugA==

"@types/node@^15.0.1":
version "15.0.1"
resolved "https://registry.yarnpkg.com/@types/node/-/node-15.0.1.tgz#ef34dea0881028d11398be5bf4e856743e3dc35a"
integrity sha512-TMkXt0Ck1y0KKsGr9gJtWGjttxlZnnvDtphxUOSd0bfaR6Q1jle+sPvrzNR1urqYTWMinoKvjKfXUGsumaO1PA==
version "15.14.1"
resolved "https://registry.yarnpkg.com/@types/node/-/node-15.14.1.tgz#4f9d3689532499fdda1c898e19f4593718655e36"
integrity sha512-wF6hazbsnwaW3GhK4jFuw5NaLDQVRQ6pWQUGAUrJzxixFkTaODSiAKMPXuHwPEPkAKQWHAzj6uJ5h+3zU9gQxg==

"@types/normalize-package-data@^2.4.0":
version "2.4.0"
Expand Down Expand Up @@ -5716,7 +5716,7 @@ ansi-styles@^4.1.0:
"@types/color-name" "^1.1.1"
color-convert "^2.0.1"

[email protected], any-promise@^1.0.0, any-promise@^1.3.0:
[email protected], any-promise@^1.0.0:
version "1.3.0"
resolved "https://registry.yarnpkg.com/any-promise/-/any-promise-1.3.0.tgz#abc6afeedcea52e809cdc0376aed3ce39635d17f"
integrity sha1-q8av7tzqUugJzcA3au0845Y10X8=
Expand Down Expand Up @@ -8826,7 +8826,7 @@ colorette@^1.2.1:
resolved "https://registry.yarnpkg.com/colorette/-/colorette-1.2.1.tgz#4d0b921325c14faf92633086a536db6e89564b1b"
integrity sha512-puCDz0CzydiSYOrnXpz/PKd69zRrribezjtE9yd4zvytoRc8+RY/KJPvtPFKZS3E3wP6neGyMe0vOTlHO5L3Pw==

colors@^1.1.2, colors@^1.4.0:
colors@^1.4.0:
version "1.4.0"
resolved "https://registry.yarnpkg.com/colors/-/colors-1.4.0.tgz#c50491479d4c1bdaed2c9ced32cf7c7dc2360f78"
integrity sha512-a+UqTh4kgZg/SlGvfbzDHpgRu7AAQOmmqRHJnxhRZICKFUT91brVhNNt58CMWU9PsBbv3PDCZUHbVxuDiH2mtA==
Expand Down Expand Up @@ -14408,11 +14408,6 @@ highlight.js@^10.0.0:
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-10.6.0.tgz#0073aa71d566906965ba6e1b7be7b2682f5e18b6"
integrity sha512-8mlRcn5vk/r4+QcqerapwBYTe+iPL5ih6xrNylxrnBdHQiijDETfXX7VIxC3UiCRiINBJfANBAsPzAvRQj8RpQ==

highlight.js@^10.4.0:
version "10.4.0"
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-10.4.0.tgz#ef3ce475e5dfa7a48484260b49ea242ddab823a0"
integrity sha512-EfrUGcQ63oLJbj0J0RI9ebX6TAITbsDBLbsjr881L/X5fMO9+oadKzEF21C7R3ULKG6Gv3uoab2HiqVJa/4+oA==

highlight.js@^10.4.1:
version "10.4.1"
resolved "https://registry.yarnpkg.com/highlight.js/-/highlight.js-10.4.1.tgz#d48fbcf4a9971c4361b3f95f302747afe19dbad0"
Expand Down Expand Up @@ -24165,13 +24160,6 @@ redent@^3.0.0:
indent-string "^4.0.0"
strip-indent "^3.0.0"

redux-cli-logger@^2.0.1:
version "2.1.0"
resolved "https://registry.yarnpkg.com/redux-cli-logger/-/redux-cli-logger-2.1.0.tgz#7e546502a4b08c7fac4fe2faee2326a6326cb4a1"
integrity sha512-75mVsggAJRSykWy2qxdGI7osocDWvc3RCMeN93hlvS/FxgdRww12NaXslez+W6gBOrSJKO7W16V0IzuISSfCxg==
dependencies:
colors "^1.1.2"

redux-devtools-core@^0.2.1:
version "0.2.1"
resolved "https://registry.yarnpkg.com/redux-devtools-core/-/redux-devtools-core-0.2.1.tgz#4e43cbe590a1f18c13ee165d2d42e0bc77a164d8"
Expand Down