This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Bug fix: update gitignore for db and delete accidentally committed file #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Likes! Thanks, @eggplantzzz.
NOTE: CI will be red because of the dependabot.yml issue.
I believe that only affects |
haltman-at
approved these changes
Oct 10, 2022
Thanks @haltman-at ! Makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe in #5599 the
typesdirectory in db got renamed totypingsto be consistent with other Truffle packages. The types file that is generated was in the .gitignore, but now with the rename it accidentally got committed. This PR fixes this by adding the correct path in the gitignore.