This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add a check to help prevent generated files being checked into source control #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
requested review from
gnidan,
benjamincburns,
cds-amal,
lsqproduction,
eggplantzzz and
sukanyaparashar
cds-amal
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem recently where a generated file was accidentally checked into source control and it caused a problem (see #5608) where bootstrapping resulted in changes to tracked files. I figured it would be good to add this measure to help prevent this. So I added a check for this in CI. Note that because this check requires bootstrapping, like
depcheckit goes in the jobs that aren'tyarncheck. Obviously this won't catch every case, but it should help, I figure.