This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add two more reminders to PR template #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
requested review from
gnidan,
benjamincburns,
cds-amal,
fainashalts,
alexandratran,
lsqproduction,
eggplantzzz,
dongmingh,
sukanyaparashar and
cliffoo
cds-amal
approved these changes
Nov 1, 2022
|
|
||
| ## Breaking changes and new features | ||
|
|
||
| - [ ] I have added any needed `breaking-change` and `new-feature` labels for the appropriate packages. |
There was a problem hiding this comment.
Should internal improvement be added here? I don't feel strongly about it, as there are many other labels that can apply, and we should use our judgement.
There was a problem hiding this comment.
Yes, I thought about adding not just "internal improvement" but that whole category -- enhancement, bug fix, dependencies -- but I didn't think it was important enough. But if people think it's important enough, that could be added too.
dongmingh
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @dongmingh's suggestion, I've added a reminder to include testing instructions. Also, I added a reminder to add any needed
breaking-changeornew-featurelabels.