Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add two more reminders to PR template #5666

Merged
merged 2 commits into from
Nov 2, 2022
+8 −0
Merged

Add two more reminders to PR template #5666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf8044c
Inculde reminder about breaking-change and new-feature labels in temp…
haltman-at Nov 1, 2022
1228053
Add reminder about testing instructions
haltman-at Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

<!-- Enter PR description here -->

## Testing instructions

<!-- Don't forget instructions about how to test the PR! -->

## Documentation

- [ ] I thought about documentation and added the `doc-change-required` label to this PR if documentation updates are required.

## Breaking changes and new features

- [ ] I have added any needed `breaking-change` and `new-feature` labels for the appropriate packages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should internal improvement be added here? I don't feel strongly about it, as there are many other labels that can apply, and we should use our judgement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought about adding not just "internal improvement" but that whole category -- enhancement, bug fix, dependencies -- but I didn't think it was important enough. But if people think it's important enough, that could be added too.