Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove image role attribute from Banner Icon component #2663

Merged
merged 5 commits into from
Jan 4, 2024
Merged

fix: Remove image role attribute from Banner Icon component #2663

merged 5 commits into from
Jan 4, 2024

Conversation

jhancock532
Copy link
Contributor

Closes #2662

@jhancock532 jhancock532 requested a review from a team as a code owner November 16, 2023 15:51
haworku
haworku previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and linking through to related issues.

@haworku
Copy link
Contributor

haworku commented Dec 27, 2023 •
edited
Loading

@jhancock532 Can you update the jest snapshot tests for src/components/banner/GovBanner/GovBanner.test.tsx failures and then ping me? I will be able to merge then

@brandonlenz
Copy link
Contributor

@all-contributors please add @jhancock532 for bug, code

@allcontributors allcontributors bot mentioned this pull request Dec 28, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@brandonlenz

I've put up a pull request to add @jhancock532! 🎉

@jhancock532
Copy link
Contributor Author

Thanks @haworku, I've updated the snapshots

@haworku haworku merged commit 8ddf443 into trussworks:main Jan 4, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haworku haworku haworku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] HTML validation errors when using <GovBanner /> component
3 participants
@jhancock532 @haworku @brandonlenz