Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove commitizen, upgrade example app dependencies #335

Merged
merged 4 commits into from
Jul 21, 2020
Merged

fix: remove commitizen, upgrade example app dependencies #335

merged 4 commits into from
Jul 21, 2020

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Jul 21, 2020 •
edited
Loading

Summary

  • Remove commitizen dependencies since we no longer lint on commits, only on PR titles (which uses a GH workflow).
  • Upgrade example app dependencies; this takes yarn audit vulnerabilities down from 4000+ to 1. Also removes a variety of lodash warnings.

Related Issues or PRs

https://github.com/trussworks/react-uswds/network/alert/example/yarn.lock/lodash/open

@haworku haworku requested a review from ahobson July 21, 2020 14:49
ahobson
ahobson previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@haworku haworku mentioned this pull request Jul 21, 2020
Closed
@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Jul 21, 2020 •
edited
Loading

Warnings
⚠️

Changes were made to yarn.lock, but no plain text yarn audit output was found in PR description. - Can you run yarn audit in your branch and paste the results inside a markdown code block?

Generated by 🚫 dangerJS against 9b84fa6

@haworku haworku requested a review from ahobson July 21, 2020 16:47
ahobson
ahobson approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haworku haworku merged commit 9c5aea2 into main Jul 21, 2020
@haworku haworku deleted the fix-lodash branch July 21, 2020 18:44
@ahobson ahobson mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahobson ahobson ahobson approved these changes

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@suzubara suzubara Awaiting requested review from suzubara

@tinyels tinyels Awaiting requested review from tinyels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haworku @trussworks-infra-zz @ahobson