[Sync]: Apply changes from DeFi wallet-core #3225

satoshiotomakan · 2023-06-13T13:42:14Z

Description

Sync DeFi wallet-core and the base TrustWallet/wallet-core.

How to test

Types of changes

Checklist

Create pull request as draft initially, unless its complete.
Filter/revert the changes
Clean the code

If you're adding a new blockchain

I have read the guidelines for adding a new blockchain.

CHANGELOG (for Wallet Core)

Add support for Syscoin (Bitcoin fork)
Add support for Verge (Bitcoin fork)
Add support for Pivx (Bitcoin fork)
Add support for Zen (Bitcoin fork)
Add support for Komodo (Zcash fork)
Add support for Binance testnet
Add support for Bitcoin Diamond (Bitcoin fork)
Add support for IOST
Add support for Stratis (Bitcoin fork)
Add support for Nebl (Verge, Bitcoin fork)
Add support for NEO Nep5 Token transfer
Extend Cosmos transaction types: add SetWithdrawAddress, ExecuteContract
Extend Oasis transaction types: add EscrowMessage, ReclaimEscrowMessage
Extend Solana transaction types: add CreateNonceAccount, WithdrawNonceAccount, AdvanceNonceAccount

BREAKING

Cosmos
- Changed the type of SigningOutput::error from string to Common.Proto.SigningError. Added SigningOutput::error_message instead.
EOS
- ExpirySeconds has been increased from 30 to 3600 seconds. Leads to changed EOS transaction hashes and signatures

CHANGELOG (for DeFi)

BREAKING

Cardano
- TokenAmoun::asset_name must be in human readable format. Added TokenAmoun::asset_name_hex instead

TODO

Merge Polkadot and Substrate blockchain implementations to work with non-added to registry.json Polkadot networks
Filecoin Signer::compile should handle Transaction::SignatureType::DELEGATED signature type: comment
Refactor NEO Protobuf messages: comment
Add Komodo blockchain the same way as it's done for Zen or BitcoinDiamond instead of relying on ZCash: comment
Fix TWBitcoinScriptLockScriptForAddressReplay in JS: comment

satoshiotomakan · 2023-06-13T15:09:03Z

include/TrustWalletCore/TWBitcoinScript.h

@@ -202,6 +202,10 @@ struct TWBitcoinScript* _Nonnull TWBitcoinScriptBuildPayToWitnessScriptHash(TWDa
 TW_EXPORT_STATIC_METHOD
 struct TWBitcoinScript* _Nonnull TWBitcoinScriptLockScriptForAddress(TWString* _Nonnull address, enum TWCoinType coin);

+/// Builds a appropriate lock script for the given address with replay.
+TW_EXPORT_STATIC_METHOD
+struct TWBitcoinScript *_Nonnull TWBitcoinScriptLockScriptForAddressReplay(TWString *_Nonnull address, enum TWCoinType coin, TWData *_Nonnull blockHash, int64_t blockHeight);


Just a note - int64_t blockHeight won't work in TypeScript.
See #3197

Let's use a string instead

Wasm has i64, maybe fine to keep it, it's weird to see string block height in Bitcoin codebase; worth to add a ts test for sure

I've added this test to wasm/tests/Blockchain/Bitcoin.test.ts:

it("test TWBitcoinScriptLockScriptForAddressReplay", () => { const { BitcoinScript, CoinType, HexCoding } = globalThis.core; const output = TW.Cardano.Proto.TxOutput.create() const toAddress = "12dNaXQtN5Asn2YFwT1cvciCrJa525fAe4" const blockHash = HexCoding.decode("1fcb84974220eb76e619d7208e1446ae9c0f755e97fb220a8f61c7dc03a0dfce") const actual = BitcoinScript.lockScriptForAddressReplay(toAddress, CoinType.bitcoin, blockHash, 123) // assert.equal(actual, "969750") });

Here is the runtime error:

UnboundTypeError: Cannot call BitcoinScript.lockScriptForAddressReplay due to unbound types: x at Error.<anonymous> (dist/lib/wallet-core.js:73:76) at new <anonymous> (dist/lib/wallet-core.js:72:261) at Wc (dist/lib/wallet-core.js:89:364) at Function.m [as lockScriptForAddressReplay] (dist/lib/wallet-core.js:128:471) at Context.<anonymous> (tests/Blockchain/Bitcoin.test.ts:24:34) at processImmediate (node:internal/timers:478:21)

We can postpone the fix of TWBitcoinScriptLockScriptForAddressReplay as our users don't use it right now, so we have some time

include/TrustWalletCore/TWKusamaAddress.h

include/TrustWalletCore/TWNEOAddress.h

include/TrustWalletCore/TWPolkadotAddress.h

include/TrustWalletCore/TWPolkadotSigner.h

satoshiotomakan · 2023-06-13T15:33:32Z

include/TrustWalletCore/TWSubstrateAddress.h

+/// Represents a Substrate address.
+TW_EXPORT_CLASS
+struct TWSubstrateAddress;


Should be replaced with TWAnyAddress

Need to extend TWSS58AddressType to include all the networks used in DeFi wallet

satoshiotomakan · 2023-06-13T15:55:39Z

include/TrustWalletCore/TWSubstrateSigner.h

+/// Builds a transaction to be broadcasted
+TW_EXPORT_STATIC_METHOD
+TWData *_Nonnull TWSubstrateSignerTransaction(TW_Substrate_Proto_SigningInput data, TWData *_Nonnull publicKey, TWData *_Nonnull signature);


I guess this can be replaced with Entry::compile.
Also `SigningInput should be passed serialized

We use it to support all coins based on substrate that we do not have to define every coin in registry.json, could we extend Entry::compile to support that?

include/TrustWalletCore/TWSubstrateSigner.h

registry.json

samples/node/index.js

Milerius

First review iteration on the interface, will check the source during the second iteration

protobuf-plugin/CMakeLists.txt

include/TrustWalletCore/TWSubstrateSigner.h

Milerius · 2023-06-14T07:39:30Z

include/TrustWalletCore/TWBitcoinScript.h

@@ -202,6 +202,10 @@ struct TWBitcoinScript* _Nonnull TWBitcoinScriptBuildPayToWitnessScriptHash(TWDa
 TW_EXPORT_STATIC_METHOD
 struct TWBitcoinScript* _Nonnull TWBitcoinScriptLockScriptForAddress(TWString* _Nonnull address, enum TWCoinType coin);

+/// Builds a appropriate lock script for the given address with replay.
+TW_EXPORT_STATIC_METHOD
+struct TWBitcoinScript *_Nonnull TWBitcoinScriptLockScriptForAddressReplay(TWString *_Nonnull address, enum TWCoinType coin, TWData *_Nonnull blockHash, int64_t blockHeight);


Let's use a string instead

include/TrustWalletCore/TWKusamaAddress.h

include/TrustWalletCore/TWPolkadotSigner.h

registry.json

samples/node/index.js

satoshiotomakan · 2023-06-14T07:59:21Z

src/Algorand/Entry.cpp

+    dataOut = txCompilerTemplate<Proto::SigningInput, Proto::SigningOutput>(
+        txInputData, [&](const auto& input, auto& output) {
+            if (signatures.size() == 0 || publicKeys.size() == 0) {
+                output.set_error(Common::Proto::Error_invalid_params);
+                output.set_error_message("empty signatures or publickeys");
+                return;
+            }
+            if (signatures.size() > 1 || publicKeys.size() > 1) {
+                output.set_error(Common::Proto::Error_no_support_n2n);
+                output.set_error_message(Common::Proto::SigningError_Name(Common::Proto::Error_no_support_n2n));
+                return;
+            }
+            output = Signer::compile(signatures[0], publicKeys[0], input);
+        });


This code snippet repeats multiple times. We could add txCompilerSingleInTemplate, for example

satoshiotomakan · 2023-06-14T08:41:29Z

src/Algorand/Signer.cpp

+    return Signer::encodeTransaction(signature, publicKey, input);
+}
+
+TW::Data Signer::preImage(const TW::PublicKey& pubKey, const Proto::SigningInput& input) noexcept {


Algorand::Signer could be refactored to avoid duplicating code by adding Signer::preImageTx() -> std::unique_ptr<BaseTransaction>.
Priority: low

satoshiotomakan · 2023-06-14T09:18:54Z

src/Bitcoin/Script.cpp

+    if (Zen::Address::isValid(string)) {
+        auto address = Zen::Address(string);
+        auto data = Data();
+        data.reserve(Address::size - 2);
+        std::copy(address.bytes.begin() + 2, address.bytes.end(), std::back_inserter(data));
+        if (address.bytes[1] == TW::p2pkhPrefix(TWCoinTypeZen)) {
+            return buildPayToPublicKeyHashReplay(data, blockHash, blockHeight);
+        } else if (address.bytes[1] == TW::p2shPrefix(TWCoinTypeZen)) {
+            return buildPayToScriptHashReplay(data, blockHash, blockHeight);
+        }
+    }


Would be great if this is implemented in Zen blockchain (e.g. in src/Zen/Script.h)

+1, also we may need to refactor Script to support OP_CHECKBLOCKATHEIGHT better

src/Bitcoin/TransactionBuilder.cpp

src/BitcoinDiamond/Transaction.cpp

satoshiotomakan · 2023-06-14T12:35:33Z

src/NEO/Entry.cpp

+void Entry::compile([[maybe_unused]] TWCoinType coin, const Data& txInputData, const std::vector<Data>& signatures, const std::vector<PublicKey>& publicKeys, Data& dataOut) const {
+    dataOut = txCompilerTemplate<Proto::SigningInput, Proto::SigningOutput>(
+        txInputData, [&](const auto& input, auto& output) {
+            if (signatures.size() == 0 || publicKeys.size() == 0) {


Probably worth to check if they have the same length

satoshiotomakan · 2023-06-14T13:24:54Z

src/Solana/Entry.cpp

@@ -34,4 +34,29 @@ string Entry::signJSON([[maybe_unused]] TWCoinType coin, const std::string& json
    return Signer::signJSON(json, key);
 }

+TW::Data Entry::preImageHashes([[maybe_unused]] TWCoinType coin, const TW::Data& txInputData) const {
+    return txCompilerTemplate<Proto::SigningInput, Proto::PreSigningOutput>(


If I understand correctly, CoinEntry::preImageHashes returns TransactionCompiler::PreSigningOutput, but also it may return Solana::PreSigningOutput and Bitcoin::PreSigningOutput.
We should return the same Protobuf message in all cases

Yes, you are right. We define them case by case.

satoshiotomakan · 2023-06-14T13:44:47Z

src/Substrate/Extrinsic.cpp

+// file LICENSE at the root of the source code distribution tree.
+
+#include "../BinaryCoding.h"
+#include "Extrinsic.h"


I hope it's possible to merge Polkadot and Substrate, because (if I'm not mistaken) there a few changes between them

src/Substrate/ScaleCodec.h

src/Tezos/Address.cpp

* Replace `Substrate::ScaleCodec` with `Polkadot::ScaleCodec`

hewigovens

Will continue review files after Bitcoin Diamond

.../app/src/androidTest/java/com/trustwallet/core/app/blockchains/cardano/TestCardanoSigning.kt

hewigovens · 2023-06-15T00:23:50Z

.../app/src/androidTest/java/com/trustwallet/core/app/blockchains/CoinAddressDerivationTests.kt

@@ -34,7 +34,9 @@ class CoinAddressDerivationTests {

    private fun runDerivationChecks(coin: CoinType, address: String?) = when (coin) {
        BINANCE -> assertEquals("bnb12vtaxl9952zm6rwf7v8jerq74pvaf77fcmvzhw", address)
+        TBINANCE -> assertEquals("tbnb12vtaxl9952zm6rwf7v8jerq74pvaf77fkw9xhl", address)


any chance we change it to binance testnet?

hewigovens · 2023-06-15T00:26:12Z

android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/eos/TestEOSSigning.kt

@@ -82,7 +82,7 @@ class TestEOSSigning {
        val signatureValue: String = signatures.get(0) as String;
        assertNotNull("Error parsing JSON result", signatureValue)
        assertEquals(
-            "SIG_K1_KfCdjsrTnx5cBpbA5cUdHZAsRYsnC9uKzuS1shFeqfMCfdZwX4PBm9pfHwGRT6ffz3eavhtkyNci5GoFozQAx8P8PBnDmj",
+            "SIG_K1_K9RdLC7DEDWjTfR64GU8BtDHcAjzR1ntcT651JMcfHNTpdsvDrUwfyzF1FkvL9fxEi2UCtGJZ9zYoNbJoMF1fbU64cRiJ7",


Need to test EOS signature

Need to test EOS signature

We changed the ExpirySeconds default value from 30 to 3600, so the signature changed.

hewigovens · 2023-06-15T00:40:18Z

include/TrustWalletCore/TWBitcoinScript.h

@@ -202,6 +202,10 @@ struct TWBitcoinScript* _Nonnull TWBitcoinScriptBuildPayToWitnessScriptHash(TWDa
 TW_EXPORT_STATIC_METHOD
 struct TWBitcoinScript* _Nonnull TWBitcoinScriptLockScriptForAddress(TWString* _Nonnull address, enum TWCoinType coin);

+/// Builds a appropriate lock script for the given address with replay.
+TW_EXPORT_STATIC_METHOD
+struct TWBitcoinScript *_Nonnull TWBitcoinScriptLockScriptForAddressReplay(TWString *_Nonnull address, enum TWCoinType coin, TWData *_Nonnull blockHash, int64_t blockHeight);


Wasm has i64, maybe fine to keep it, it's weird to see string block height in Bitcoin codebase; worth to add a ts test for sure

include/TrustWalletCore/TWCoinType.h

src/Bitcoin/Script.cpp

hewigovens · 2023-06-15T01:14:42Z

src/Bitcoin/Script.cpp

@@ -33,6 +34,12 @@ bool Script::isPayToScriptHash() const {
           bytes[22] == OP_EQUAL;
 }

+bool Script::isPayToScriptHashReplay() const {
+    // Extra-fast test for pay-to-script-hash-replay


there is no pay-to-script-hash-replay, still pay-to-script-hash

hewigovens · 2023-06-15T01:16:03Z

src/Bitcoin/Script.cpp

+    if (Zen::Address::isValid(string)) {
+        auto address = Zen::Address(string);
+        auto data = Data();
+        data.reserve(Address::size - 2);
+        std::copy(address.bytes.begin() + 2, address.bytes.end(), std::back_inserter(data));
+        if (address.bytes[1] == TW::p2pkhPrefix(TWCoinTypeZen)) {
+            return buildPayToPublicKeyHashReplay(data, blockHash, blockHeight);
+        } else if (address.bytes[1] == TW::p2shPrefix(TWCoinTypeZen)) {
+            return buildPayToScriptHashReplay(data, blockHash, blockHeight);
+        }
+    }


+1, also we may need to refactor Script to support OP_CHECKBLOCKATHEIGHT better

hewigovens · 2023-06-15T01:17:51Z

src/Bitcoin/Script.h

@@ -113,6 +137,35 @@ class Script {
        return OP_1 + uint8_t(n - 1);
    }

+    /// Encodes an integer
+    static inline Data encodeNumber(int64_t n) {


move it to a separate file

src/Bitcoin/SegwitAddress.cpp

satoshiotomakan · 2023-06-15T09:18:50Z

src/Theta/Signer.h

+    Proto::SigningInput input;
+    /// Initializes a transaction signer.
+    explicit Signer(const Proto::SigningInput& input) : chainID(input.chain_id()), input(input) {}


There is no need to hold Proto::SigningInput input in the Theta::Signer class.
Priority: low

satoshiotomakan · 2023-06-15T09:40:29Z

src/XRP/Signer.h

+    Proto::SigningInput input;
+
+    Signer() = default;
+
+    /// Initializes a transaction signer.
+    explicit Signer(const Proto::SigningInput& input) : input(input) {}


I believe we don't need to hold Proto::SigningInput input in XRP::Signer.
Priority: low

satoshiotomakan · 2023-06-15T09:49:08Z

src/Zcash/Entry.cpp

+    if (coin == TWCoinTypeKomodo) {
+        auto* base58Prefix = std::get_if<Base58Prefix>(&addressPrefix);
+        return base58Prefix ? Bitcoin::Address::isValid(address, {{base58Prefix->p2pkh}, {base58Prefix->p2sh}}) : false;
+    }


I think we should create a separate Komodo blockchain the same way as it's done for Zen or BitcoinDiamond instead of checking the coin type.

Added to TODO list

src/Zen/TransactionBuilder.h

src/interface/TWTransactionCompiler.cpp

src/proto/Cosmos.proto

satoshiotomakan · 2023-06-15T10:47:08Z

src/proto/NEO.proto

@@ -57,6 +99,7 @@ message SigningInput {

    // Optional transaction plan (if missing it will be computed)
    TransactionPlan plan = 7;
+    Transaction transaction = 8;


Probably, Transaction message should be renamed to TransactionOperation or TransctionInvocation

// Transaction message TransactionOperation { // nep5 token transfer transaction message Nep5Transfer { } // Generic invocation transaction message InvocationGeneric { } oneof operation_oneof { Nep5Transfer nep5_transfer = 1; InvocationGeneric invocation_generic = 2; } }

Added to TODO list

src/proto/Substrate.proto

src/proto/Cosmos.proto

src/Kusama/Address.h

src/NEO/Address.h

src/Polkadot/Address.h

w20089527 · 2023-06-16T05:55:15Z

src/Polkadot/Extrinsic.cpp

    {stakingChill, Data{0x07, 0x06}},
    {utilityBatch, Data{0x1a, 0x02}},
+    {stakingReBond, Data{0x07, 0x13}},


Indices may be changed if Polkadot or substrate upgrades, this happened on Polymesh.

* Remove unused TW interfaces * Rename `TWCoinTypeDeriveAddressFromDerivation` to `TWCoinTypeDeriveAddressFromPublicKeyAndDerivation`

* Add `txCompilerSingleTemplate`

* Revert `TW` prefix changes

satoshiotomakan · 2023-06-15T15:30:53Z

tests/chains/Binance/SignerTests.cpp

-              "208094ebdc032801126e0a26eb5ae9872103a9a55c040c8eb8120f3d1b32193250841c08af44ea561aac"
-              "993dbe0f6b6a8fc71240b2612500b80f5ee8fab1574e9b1763fd898a7048910d02e00dea6337d3c848c9"
-              "5aa2213db595179db076dfdb10f6e2d9b2aa76c9cd3ee11396ac224991e3e0cd180f2001");
+        "208094ebdc032801126e0a26eb5ae9872103a9a55c040c8eb8120f3d1b32193250841c08af44ea561aac993dbe0f6b6a8fc712401fbb993d643f03b3e8e757a502035f58c4c45aaaa6e107a3059ab7c6164283c10f1254e87feee21477c64c87b1a27d8481048533ae2f685b3ac0dc66e4edbc0b180f2001"
+    );


Please note that Binance signatures have been changed

src/proto/Substrate.proto

satoshiotomakan · 2023-06-16T10:27:13Z

src/proto/NEO.proto

@@ -57,6 +99,7 @@ message SigningInput {

    // Optional transaction plan (if missing it will be computed)
    TransactionPlan plan = 7;
+    Transaction transaction = 8;


Added to TODO list

satoshiotomakan · 2023-06-16T10:27:25Z

src/Zcash/Entry.cpp

+    if (coin == TWCoinTypeKomodo) {
+        auto* base58Prefix = std::get_if<Base58Prefix>(&addressPrefix);
+        return base58Prefix ? Bitcoin::Address::isValid(address, {{base58Prefix->p2pkh}, {base58Prefix->p2sh}}) : false;
+    }


Added to TODO list

src/Bitcoin/SegwitAddress.cpp

* Simplify `Binance::Address`

satoshiotomakan · 2023-06-19T10:28:08Z

tests/chains/EOS/TWAnySignerTests.cpp

@@ -39,7 +39,7 @@ TEST(TWAnySignerEOS, Sign) {
        ANY_SIGN(input, TWCoinTypeEOS);

        EXPECT_EQ(output.error(), Common::Proto::OK);
-        EXPECT_EQ(output.json_encoded(), R"({"compression":"none","packed_context_free_data":"","packed_trx":"7c59a35cd6679a1f3d4800000000010000000080a920cd000000572d3ccdcd010000000080a920cd00000000a8ed3232330000000080a920cd0000000000ea3055e09304000000000004544b4e00000000126d79207365636f6e64207472616e7366657200","signatures":["SIG_K1_KfCdjsrTnx5cBpbA5cUdHZAsRYsnC9uKzuS1shFeqfMCfdZwX4PBm9pfHwGRT6ffz3eavhtkyNci5GoFozQAx8P8PBnDmj"]})");
+        EXPECT_EQ(output.json_encoded(), R"({"compression":"none","packed_context_free_data":"","packed_trx":"6e67a35cd6679a1f3d4800000000010000000080a920cd000000572d3ccdcd010000000080a920cd00000000a8ed3232330000000080a920cd0000000000ea3055e09304000000000004544b4e00000000126d79207365636f6e64207472616e7366657200","signatures":["SIG_K1_K9RdLC7DEDWjTfR64GU8BtDHcAjzR1ntcT651JMcfHNTpdsvDrUwfyzF1FkvL9fxEi2UCtGJZ9zYoNbJoMF1fbU64cRiJ7"]})");


I believe the signature has been changed due to the changed ExpirySeconds

* [r2r]: Add ThetaFuel EVM compatible chain * [r2r]: Bump wc-kotlin version to 3.1.38 (#3218) * [ERC-4337] Fix user operation hash mistake (#3228) * [ERC-4337] Fix user operation hash mistake * Update TestBarz.kt --------- Co-authored-by: hewigovens <[email protected]> * [r2r] Update starknet-ff crate (#3230) * [Sync]: Apply changes from DeFi wallet-core (#3225) * [Barz] Format signature API changes (#3241) * [Barz] Public API refactoring (#3212) * Getting rid of attestationObject in Barz public API * remove duplicates * Update Barz.cpp * Update Barz.cpp * Update BarzTests.swift * update tests * Update WebAuthnTests.cpp * Update TestBarz.kt * Update TestWebAuthn.kt * update android tests * Update TestBarz.kt * Update TestBarz.kt * Update TestBarz.kt * fix nullability * tests update * Add support for Taproot and BRC20 (#3233) * [Barz] Add TokenReceiverFacet support (#3240) * [CFX]: Add support for Conflux eSpace (#3259) * [License]: update to apache 2.0 (#3256) * [Barz] Execute batch (#3257) * [Kotlin] Fixed GH Action (#3263) * feat(evm/thorchain): use depositWithExpiry for regular transfer (#3266) * feat(swift): update to 3.2.1 (#3269) * Add iOS and android tests to check if new methods available (#3267) * [WASM] Fixed CoinType.deriveAddressFromPublicKeyAndDerivation (#3271) * [Polkadot]: Refactor Polkadot to support any Substrate chain (#3261) * [Acala]: Add Acala and AcalaEVM chains (#3274) * [Kotlin] Added UInt value to enums (#3276) Co-authored-by: Sztergbaum Roman <[email protected]> * fix(bitcoin): Fix `TWAnySignerPlan` (#3278) * [README]: Update README.md (#3280) Removed broken IFWallet link Updated supported blockchain count according to registry.md Corrected some typos and grammatical mistakes * [Chain/EVM]: add opbnb testnet (#3291) * [Barz] Upgrade to the new Barz contract constructor (#3288) * [Polkadot]: Fix `Staking::Bond` and `Staking::BondAndNominate` (#3293) * [Webauthn] Add some helpers to extract P256 values (#3292) * [Cardano] Support utxo with legacy(byron) address (#3284) * [Cardano]: Fix signing in JS (#3299) --------- Co-authored-by: Ruslan Serebriakov <[email protected]> Co-authored-by: hewigovens <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Maxim Pestryakov <[email protected]> Co-authored-by: Sabuhi Fatalizada <[email protected]> Co-authored-by: Sergey Balashov <[email protected]>

Apply changes from DeFi wallet-core

8accc66

satoshiotomakan requested review from Milerius and lamafab as code owners June 13, 2023 13:42

satoshiotomakan marked this pull request as draft June 13, 2023 13:42

Milerius requested a review from hewigovens June 13, 2023 14:26

Clean code #1

5b922f6

satoshiotomakan commented Jun 13, 2023

View reviewed changes

Milerius requested changes Jun 14, 2023

View reviewed changes

Milerius requested a review from w20089527 June 14, 2023 10:04

Clean code 2 (minor changes)

8f6218b

satoshiotomakan commented Jun 14, 2023

View reviewed changes

Clean code 3

048c39e

* Replace `Substrate::ScaleCodec` with `Polkadot::ScaleCodec`

hewigovens reviewed Jun 15, 2023

View reviewed changes

satoshiotomakan commented Jun 15, 2023

View reviewed changes

satoshiotomakan added 2 commits June 15, 2023 13:14

Clean code 4

35e83b4

[Cardano]: Add asset_name_hex property to TokenAmount

e25883a

satoshiotomakan marked this pull request as ready for review June 15, 2023 15:44

Clean code 5

2ef41c9

w20089527 reviewed Jun 16, 2023

View reviewed changes

src/Kusama/Address.h Outdated Show resolved Hide resolved

w20089527 reviewed Jun 16, 2023

View reviewed changes

src/NEO/Address.h Outdated Show resolved Hide resolved

w20089527 reviewed Jun 16, 2023

View reviewed changes

src/Polkadot/Address.h Outdated Show resolved Hide resolved

w20089527 reviewed Jun 16, 2023

View reviewed changes

satoshiotomakan added 5 commits June 16, 2023 09:56

Fix compile errors

4d02e0d

Clean code 6

afa060d

* Remove unused TW interfaces * Rename `TWCoinTypeDeriveAddressFromDerivation` to `TWCoinTypeDeriveAddressFromPublicKeyAndDerivation`

Clean code 7

2e09219

* Add `txCompilerSingleTemplate`

Clean code 8

64120a7

* Revert `TW` prefix changes

Fix unit tests

c9ae4b9

satoshiotomakan commented Jun 16, 2023

View reviewed changes

satoshiotomakan added 2 commits June 19, 2023 10:24

Clean code 9

30e74f1

* Simplify `Binance::Address`

Clean code 10

e1b4b0a

Update kmp wc to 3.1.39

61ee61a

satoshiotomakan commented Jun 19, 2023

View reviewed changes

Merge branch 'master' into s/sync-defi-repo

b794af0

Milerius approved these changes Jun 19, 2023

View reviewed changes

hewigovens approved these changes Jun 19, 2023

View reviewed changes

Milerius merged commit 3769f31 into master Jun 19, 2023

Milerius deleted the s/sync-defi-repo branch June 19, 2023 12:00

satoshiotomakan mentioned this pull request Jun 30, 2023

[Bitcoin]: Fix TWAnySignerPlan if use_max_amount = true #3278

Merged

5 tasks

[Sync]: Apply changes from DeFi wallet-core #3225

[Sync]: Apply changes from DeFi wallet-core #3225

Conversation

satoshiotomakan commented Jun 13, 2023 • edited Loading

Description

How to test

Types of changes

Checklist

CHANGELOG (for Wallet Core)

BREAKING

CHANGELOG (for DeFi)

BREAKING

TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Milerius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hewigovens left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satoshiotomakan commented Jun 13, 2023 •

edited

Loading