[Polkadot]: Fix Staking::Bond and Staking::BondAndNominate
#3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamafab
previously approved these changes
Jul 6, 2023
src/Polkadot/Extrinsic.cpp
Outdated
|
|
||
| bool polkadotOrKusama = network == static_cast<uint32_t>(TWSS58AddressTypePolkadot) | ||
| || network == static_cast<uint32_t>(TWSS58AddressTypeKusama); | ||
| if (polkadotOrKusama && specVersion >= stakingControllerSpecVersion) { |
There was a problem hiding this comment.
What's the point of checking specVersion? There's no way of going back :)
There was a problem hiding this comment.
I've rolled back these changes, thank you for the note!
I was thinking about this yesterday, and came to the decision that it is better to do version checking on the end-user app side
Milerius
approved these changes
Jul 7, 2023
Milerius
added a commit
that referenced
this pull request
Jul 17, 2023
* [r2r]: Add ThetaFuel EVM compatible chain * [r2r]: Bump wc-kotlin version to 3.1.38 (#3218) * [ERC-4337] Fix user operation hash mistake (#3228) * [ERC-4337] Fix user operation hash mistake * Update TestBarz.kt --------- Co-authored-by: hewigovens <[email protected]> * [r2r] Update starknet-ff crate (#3230) * [Sync]: Apply changes from DeFi wallet-core (#3225) * [Barz] Format signature API changes (#3241) * [Barz] Public API refactoring (#3212) * Getting rid of attestationObject in Barz public API * remove duplicates * Update Barz.cpp * Update Barz.cpp * Update BarzTests.swift * update tests * Update WebAuthnTests.cpp * Update TestBarz.kt * Update TestWebAuthn.kt * update android tests * Update TestBarz.kt * Update TestBarz.kt * Update TestBarz.kt * fix nullability * tests update * Add support for Taproot and BRC20 (#3233) * [Barz] Add TokenReceiverFacet support (#3240) * [CFX]: Add support for Conflux eSpace (#3259) * [License]: update to apache 2.0 (#3256) * [Barz] Execute batch (#3257) * [Kotlin] Fixed GH Action (#3263) * feat(evm/thorchain): use depositWithExpiry for regular transfer (#3266) * feat(swift): update to 3.2.1 (#3269) * Add iOS and android tests to check if new methods available (#3267) * [WASM] Fixed CoinType.deriveAddressFromPublicKeyAndDerivation (#3271) * [Polkadot]: Refactor Polkadot to support any Substrate chain (#3261) * [Acala]: Add Acala and AcalaEVM chains (#3274) * [Kotlin] Added UInt value to enums (#3276) Co-authored-by: Sztergbaum Roman <[email protected]> * fix(bitcoin): Fix `TWAnySignerPlan` (#3278) * [README]: Update README.md (#3280) Removed broken IFWallet link Updated supported blockchain count according to registry.md Corrected some typos and grammatical mistakes * [Chain/EVM]: add opbnb testnet (#3291) * [Barz] Upgrade to the new Barz contract constructor (#3288) * [Polkadot]: Fix `Staking::Bond` and `Staking::BondAndNominate` (#3293) * [Webauthn] Add some helpers to extract P256 values (#3292) * [Cardano] Support utxo with legacy(byron) address (#3284) * [Cardano]: Fix signing in JS (#3299) --------- Co-authored-by: Ruslan Serebriakov <[email protected]> Co-authored-by: hewigovens <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Maxim Pestryakov <[email protected]> Co-authored-by: Sabuhi Fatalizada <[email protected]> Co-authored-by: Sergey Balashov <[email protected]>
satoshiotomakan
added a commit
that referenced
this pull request
Jul 17, 2023
* [r2r]: Add ThetaFuel EVM compatible chain * [r2r]: Bump wc-kotlin version to 3.1.38 (#3218) * [ERC-4337] Fix user operation hash mistake (#3228) * [ERC-4337] Fix user operation hash mistake * Update TestBarz.kt --------- Co-authored-by: hewigovens <[email protected]> * [r2r] Update starknet-ff crate (#3230) * [Sync]: Apply changes from DeFi wallet-core (#3225) * [Barz] Format signature API changes (#3241) * [Barz] Public API refactoring (#3212) * Getting rid of attestationObject in Barz public API * remove duplicates * Update Barz.cpp * Update Barz.cpp * Update BarzTests.swift * update tests * Update WebAuthnTests.cpp * Update TestBarz.kt * Update TestWebAuthn.kt * update android tests * Update TestBarz.kt * Update TestBarz.kt * Update TestBarz.kt * fix nullability * tests update * Add support for Taproot and BRC20 (#3233) * [Barz] Add TokenReceiverFacet support (#3240) * [CFX]: Add support for Conflux eSpace (#3259) * [License]: update to apache 2.0 (#3256) * [Barz] Execute batch (#3257) * [Kotlin] Fixed GH Action (#3263) * feat(evm/thorchain): use depositWithExpiry for regular transfer (#3266) * feat(swift): update to 3.2.1 (#3269) * Add iOS and android tests to check if new methods available (#3267) * [WASM] Fixed CoinType.deriveAddressFromPublicKeyAndDerivation (#3271) * [Polkadot]: Refactor Polkadot to support any Substrate chain (#3261) * [Acala]: Add Acala and AcalaEVM chains (#3274) * [Kotlin] Added UInt value to enums (#3276) Co-authored-by: Sztergbaum Roman <[email protected]> * fix(bitcoin): Fix `TWAnySignerPlan` (#3278) * [README]: Update README.md (#3280) Removed broken IFWallet link Updated supported blockchain count according to registry.md Corrected some typos and grammatical mistakes * [Chain/EVM]: add opbnb testnet (#3291) * [Barz] Upgrade to the new Barz contract constructor (#3288) * [Polkadot]: Fix `Staking::Bond` and `Staking::BondAndNominate` (#3293) * [Webauthn] Add some helpers to extract P256 values (#3292) * [Cardano] Support utxo with legacy(byron) address (#3284) * [Cardano]: Fix signing in JS (#3299) --------- Co-authored-by: Ruslan Serebriakov <[email protected]> Co-authored-by: hewigovens <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Maxim Pestryakov <[email protected]> Co-authored-by: Sabuhi Fatalizada <[email protected]> Co-authored-by: Sergey Balashov <[email protected]>
satoshiotomakan
added a commit
that referenced
this pull request
Oct 6, 2023
* [r2r]: Add ThetaFuel EVM compatible chain * [r2r]: Bump wc-kotlin version to 3.1.38 (#3218) * [ERC-4337] Fix user operation hash mistake (#3228) * [ERC-4337] Fix user operation hash mistake * Update TestBarz.kt --------- Co-authored-by: hewigovens <[email protected]> * [r2r] Update starknet-ff crate (#3230) * [Sync]: Apply changes from DeFi wallet-core (#3225) * [Barz] Format signature API changes (#3241) * [Barz] Public API refactoring (#3212) * Getting rid of attestationObject in Barz public API * remove duplicates * Update Barz.cpp * Update Barz.cpp * Update BarzTests.swift * update tests * Update WebAuthnTests.cpp * Update TestBarz.kt * Update TestWebAuthn.kt * update android tests * Update TestBarz.kt * Update TestBarz.kt * Update TestBarz.kt * fix nullability * tests update * Add support for Taproot and BRC20 (#3233) * [Barz] Add TokenReceiverFacet support (#3240) * [CFX]: Add support for Conflux eSpace (#3259) * [License]: update to apache 2.0 (#3256) * [Barz] Execute batch (#3257) * [Kotlin] Fixed GH Action (#3263) * feat(evm/thorchain): use depositWithExpiry for regular transfer (#3266) * feat(swift): update to 3.2.1 (#3269) * Add iOS and android tests to check if new methods available (#3267) * [WASM] Fixed CoinType.deriveAddressFromPublicKeyAndDerivation (#3271) * [Polkadot]: Refactor Polkadot to support any Substrate chain (#3261) * [Acala]: Add Acala and AcalaEVM chains (#3274) * [Kotlin] Added UInt value to enums (#3276) Co-authored-by: Sztergbaum Roman <[email protected]> * fix(bitcoin): Fix `TWAnySignerPlan` (#3278) * [README]: Update README.md (#3280) Removed broken IFWallet link Updated supported blockchain count according to registry.md Corrected some typos and grammatical mistakes * [Chain/EVM]: add opbnb testnet (#3291) * [Barz] Upgrade to the new Barz contract constructor (#3288) * [Polkadot]: Fix `Staking::Bond` and `Staking::BondAndNominate` (#3293) * [Webauthn] Add some helpers to extract P256 values (#3292) * [Cardano] Support utxo with legacy(byron) address (#3284) * [Cardano]: Fix signing in JS (#3299) --------- Co-authored-by: Ruslan Serebriakov <[email protected]> Co-authored-by: hewigovens <[email protected]> Co-authored-by: Fabio Lama <[email protected]> Co-authored-by: Sztergbaum Roman <[email protected]> Co-authored-by: Maxim Pestryakov <[email protected]> Co-authored-by: Sabuhi Fatalizada <[email protected]> Co-authored-by: Sergey Balashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bond::controllercan be omitted manually for custom Polkadot chains.How to test
Run C++ tests
Checklist
If you're adding a new blockchain