Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a list of variables to be read in as a dictionary instead of GC_var approach #112

Open
tsherwen opened this issue Sep 15, 2021 · 1 comment
Assignees

Comments

@tsherwen
Copy link
Owner

Allow for a list of variables to be read in as a dictionary instead of the current (e.g. AC.GC_var()) approach.

Currently, variables are stored in an inline list/dict in variables.py, but this would be cleaner if stored in a yml file.

@tsherwen tsherwen self-assigned this Sep 15, 2021
@tsherwen
Copy link
Owner Author

tsherwen commented Sep 15, 2021

Done a test implementation for 3 functions in variables.py using a YAML read. Generally working fine.

Issues to fix:

  • processing of LaTeX strings (e.g. read in of '$\mu$g m$^{-3}$' as '$\mu$g m$^{-3}$' (this will need to be fixed before using this method for latex_spec_name() calls )
  • blocks of family assignments (e.g. subfamilies within spec_stoich() )

tsherwen added a commit that referenced this issue Sep 15, 2021
This intial implimentation is related to issue #112.

Signed-off-by: [email protected] <[email protected]>
tsherwen added a commit that referenced this issue May 9, 2022
This intial implimentation is related to issue #112.

Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant