Catching value of undefined from localStorage.getItem #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @SilVdB and thank you for your contribution. Is this causing third party libraries to crash? If yes, let's find a test case that fails and confirm that this actually solves the problem. |
kounelios13
reviewed
Sep 21, 2017
|
@kounelios13 that's right, I've coded this a while back and it's not bulletproof. Thanks @SilVdB for the catch. Can you update the code in your pull request in order to merge? |
|
Actually PR #53 solves of these issues so I'm going to accept that instead. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this when trying to test modules that use Lockr: when localStorage is not available, a JSON.parse of localStorage.getItem() returns undefined, not null.