shortened return expressions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Lockr.get` got an extra checking for `null` at the beginning and I removed it since you're doing a check for key `data` and it will return `undefined` too in case of `null` - `Lockr.smembers` I add a one line expression since you just want to check the existing of `value` object and it's key `data` so the one line expression will cause less lines in the source files
|
@KhaledElAnsari specs are green, so we can go ahead and merge. Can you remove |
|
@tsironis all good now just did what you asked for |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lockr.getgot an extra checking fornullat the beginning and I removed it since you're doing a check for keydataand it will returnundefinedtoo in case ofnullLockr.smembersI add a one line expression since you just want to check the existing ofvalueobject and it's keydataso the one line expression will cause less lines in the source files