Change CLI fileExtension to nil #208
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's another problem with this that this PR does not solve. CLI target's explicitFileType should be set to |
keith
force-pushed
the
ks/cli-extension
branch
from
85b2595 to
9b53b5b
Compare
pepicrft
approved these changes
Dec 27, 2017
The fileExtension property is used upstream to determine the explicitFileType of the file reference. If that property exists but is empty Xcode crashes. Previously that was the case with the tool file type since the product target had an empty explicitFileType. With this change it now omits that property instead, and still has no extension.
keith
force-pushed
the
ks/cli-extension
branch
from
9b53b5b to
364970e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fileExtension property is used upstream to determine the
explicitFileType of the file reference. If that property exists but is
empty Xcode crashes. Previously that was the case with the tool file
type since the product target had an empty explicitFileType. With this
change it now omits that property instead, and still has no extension.
This change is