Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Testables element ordering #702

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

maxwellE
Copy link
Contributor

@maxwellE maxwellE commented Jul 7, 2022

Testables should come after MacroExpansion (Xcode expects this and
will edit projects with invalid order).

`Testables` should come after `MacroExpansion` (Xcode expects this and
will edit projects with invalid order).
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #702 (cb72bed) into main (e02240f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   84.92%   84.83%   -0.09%     
==========================================
  Files         157      157              
  Lines        9109     9109              
==========================================
- Hits         7736     7728       -8     
- Misses       1373     1381       +8     
Impacted Files Coverage Δ
Sources/XcodeProj/Scheme/XCScheme+TestAction.swift 91.03% <100.00%> (ø)
Sources/XcodeProj/Errors/Errors.swift 36.11% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b61781...cb72bed. Read the comment docs.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxwellE

Verified via inspecting a manually created project in Xcode and selecting a "Expand Variables Based On" target within the test action

Screenshot 2022-07-07 at 07 39 10

<TestAction
      buildConfiguration = "Debug"
      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
      shouldUseLaunchSchemeArgsEnv = "NO">
      <MacroExpansion>
         <BuildableReference
            BuildableIdentifier = "primary"
            BlueprintIdentifier = "FBA856212875AC7B007ABE1A"
            BuildableName = "AsyncTrials.framework"
            BlueprintName = "AsyncTrials"
            ReferencedContainer = "container:AsyncTrials.xcodeproj">
         </BuildableReference>
      </MacroExpansion>
      <Testables>
         <TestableReference
            skipped = "NO">
            <BuildableReference
               BuildableIdentifier = "primary"
               BlueprintIdentifier = "FBA856292875AC7C007ABE1A"
               BuildableName = "AsyncTrialsTests.xctest"
               BlueprintName = "AsyncTrialsTests"
               ReferencedContainer = "container:AsyncTrials.xcodeproj">
            </BuildableReference>
         </TestableReference>
      </Testables>
   </TestAction>

Copy link
Collaborator

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luispadron luispadron merged commit 2fa16ab into tuist:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants