Group builder (#59)

* Group and policy builders - add display name
turbonomic · Jan 14, 2019 · aed6fd0 · aed6fd0
1 parent 8f47c27
commit aed6fd0
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/pkg/builder/group/group_builder.go b/pkg/builder/group/group_builder.go
@@ -19,6 +19,7 @@ const (
 // Builder for creating a GroupDTO
 type AbstractBuilder struct {
 	groupId          string
+	displayName      string
 	entityTypePtr    *proto.EntityDTO_EntityType
 	memberList       []string
 	matching         *Matching
@@ -66,6 +67,10 @@ func (groupBuilder *AbstractBuilder) Build() (*proto.GroupDTO, error) {
 		Info:        groupId,
 	}
 
+	if groupBuilder.displayName != "" {
+		groupDTO.DisplayName = &groupBuilder.displayName
+	}
+
 	err := groupBuilder.setupEntityType(groupDTO)
 	if err != nil {
 		groupBuilder.ec.Collect(err)
@@ -93,6 +98,16 @@ func (groupBuilder *AbstractBuilder) Build() (*proto.GroupDTO, error) {
 	return groupDTO, nil
 }
 
+func (groupBuilder *AbstractBuilder) WithDisplayName(displayName string) *AbstractBuilder {
+	if displayName == "" {
+		return groupBuilder
+	}
+	// Setup entity type
+	groupBuilder.displayName = displayName
+
+	return groupBuilder
+}
+
 // Set the entity type for the members of the group.
 // All the entities in a group belong to the same entity type.
 func (groupBuilder *AbstractBuilder) OfType(eType proto.EntityDTO_EntityType) *AbstractBuilder {

diff --git a/pkg/builder/group/group_builder_test.go b/pkg/builder/group/group_builder_test.go
@@ -152,3 +152,22 @@ func TestGroupBuilderSetConsistentResize(t *testing.T) {
 
 	fmt.Printf("%++v\n", groupDTO)
 }
+
+func TestGroupBuilderDisplayName(t *testing.T) {
+	id := "group1"
+	eType := proto.EntityDTO_CONTAINER
+
+	groupBuilder := StaticGroup(id).
+		OfType(eType).
+		WithEntities([]string{"abc", "xyz"})
+
+	groupDTO, _ := groupBuilder.Build()
+
+	assert.Equal(t, id, groupDTO.GetDisplayName())
+
+	displayName := "Test Group"
+	groupBuilder.WithDisplayName(displayName)
+	groupDTO, _ = groupBuilder.Build()
+
+	assert.Equal(t, displayName, groupDTO.GetDisplayName())
+}