Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group builder #59

Merged
merged 10 commits into from
Jan 14, 2019
Merged

Group builder #59

merged 10 commits into from
Jan 14, 2019

Conversation

pallavidn
Copy link
Contributor

@pallavidn pallavidn commented Jan 14, 2019 •
edited
Loading

Added to group builder:

  • Group Display name

@pallavidn pallavidn requested a review from maxwangvmt January 14, 2019 16:13
@coveralls
Copy link

coveralls commented Jan 14, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 50.925% when pulling bc5edda on pallavidn:group-builder into 8f47c27 on turbonomic:master.

maxwangvmt
maxwangvmt approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@maxwangvmt maxwangvmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pallavidn pallavidn merged commit aed6fd0 into turbonomic:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwangvmt maxwangvmt maxwangvmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallavidn @coveralls @maxwangvmt