filestore: Fix .info file not deleted if the binary file was successfully deleted
#1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acconut
changed the title
.info file not deleted in filestore if the bin file was successfully deleted.info file not deleted if the binary file was successfully deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where if the bin file was deleted without errors in the filestore, the
.infofile would not be deleted.The main issue is that the
!errors.Is(err, os.ErrNotExist)check is being made without checking thaterris actually notnil. Thenilvalue will pass thisifcase and the subsequent cleanup of.infofile will not happen in that case because the function returns at that point.I checked the fix in my setup and now it actually removes the
.infofile as well.