Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestore: Fix .info file not deleted if the binary file was successfully deleted #1214

Merged
merged 1 commit into from
Nov 12, 2024
Merged

filestore: Fix .info file not deleted if the binary file was successfully deleted #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/filestore/filestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,12 @@ func (upload *fileUpload) Terminate(ctx context.Context) error {
// to delete them anyways. The files might be removed by a cron job for cleaning up
// or some file might have been removed when tusd crashed during the termination.
err := os.Remove(upload.binPath)
if !errors.Is(err, os.ErrNotExist) {
if err != nil && !errors.Is(err, os.ErrNotExist) {
return err
}

err = os.Remove(upload.infoPath)
if !errors.Is(err, os.ErrNotExist) {
if err != nil && !errors.Is(err, os.ErrNotExist) {
return err
}

Expand Down