Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

[v1] Support new grid #420

Merged
merged 1 commit into from
Nov 10, 2018
Merged

[v1] Support new grid #420

merged 1 commit into from
Nov 10, 2018

Conversation

Herst
Copy link
Collaborator

@Herst Herst commented Sep 18, 2018 •
edited
Loading

Changes

Ports over the following checks:

  • W009 (empty spacer column)
  • E005 (row and col on same element)
  • E012 (input-group and col on the same element)
  • E013 (invalid children of rows)
  • E014 (invalid parent of cols)
  • E029 (redundant col classes)
  • E037 (zero width col classes)
  • E051 (float style and col)
  • E052 (float style and row)

All of them existed already in the original Bootlint.

Status

  • Code: Done
  • Tests: Done (but hopefully I didn't delete some too much, need to check)
  • Wiki: Done

Notes

  • Simplified the empty column message generation a lot. Since the user is pointed to the Wiki it could be explained in more detail there.
  • No idea what is with .clearfix in relationship with E013, I left it in there for now but I am not sure it is useful with the new column model (@mdo).
  • I didn't adapt the wiki page examples in relationship to .form-row.

@Herst Herst changed the title Support new grid [v.next] Support new grid Sep 18, 2018
Johann-S
Johann-S suggested changes Sep 18, 2018
View reviewed changes
Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not push your .idea folder

.idea/bootlint-ng.iml Outdated Show resolved Hide resolved
test/fixtures/grid/col-xl-0.html Show resolved Hide resolved
@Herst
Support new grid
bf2be42 
Ports the following checks:

- W009 (empty spacer column)
- E005 (row and col on same element)
- E012 (input-group and col on the same element)
- E013 (invalid children of rows)
- E014 (invalid parent of cols)
- E029 (col 0 classes)
- E037 (float classes and col)
- E051 (float style and col)
- E052 (float style and row)
@Herst Herst self-assigned this Sep 21, 2018
@Herst Herst mentioned this pull request Sep 24, 2018
Merged
@Herst Herst merged commit f8faf45 into next Nov 10, 2018
@Herst Herst added this to the v1.0.0 milestone Nov 10, 2018
@XhmikosR XhmikosR deleted the next-new-grid branch July 28, 2019 09:05
@Herst Herst changed the title [v.next] Support new grid [v1] Support new grid Jul 31, 2019
@Herst Herst mentioned this pull request Jul 31, 2019
Open
66 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebbet hebbet hebbet left review comments

@Johann-S Johann-S Johann-S requested changes

Assignees

@Herst Herst

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Herst @hebbet @Johann-S