Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

[v1] New container-related checks #422

Merged
merged 1 commit into from
Jul 28, 2019
Merged

[v1] New container-related checks #422

merged 1 commit into from
Jul 28, 2019

Conversation

Herst
Copy link
Collaborator

@Herst Herst commented Sep 18, 2018

Add E003 (misplaced .row), and remove E004 (nestable containers) since that works now.

Status

  • Code: Done
  • Tests: Done
  • Wiki: Done

@Herst Herst changed the title Container-related checks [v.next] Container-related checks Sep 18, 2018
@Herst Herst self-assigned this Sep 21, 2018
@Herst
Copy link
Collaborator Author

Herst commented Sep 24, 2018

Oops, some of the tests use the old column classes, now I am in a quandary, fixing this would make this PR depended on #420.

@Herst Herst force-pushed the next branch 2 times, most recently from 622ae8b to 65d8daf Compare November 10, 2018 17:34
@Herst Herst changed the title [v.next] Container-related checks [v1] Container-related checks Dec 26, 2018
@Herst
Copy link
Collaborator Author

Herst commented Dec 26, 2018

Oops, some of the tests use the old column classes, now I am in a quandary, fixing this would make this PR depended on #420.

Rebased it now with the new column classes.

@Herst Herst added this to the v1.0.0 milestone Dec 26, 2018
@Herst
Copy link
Collaborator Author

Herst commented Dec 26, 2018

/cc @XhmikosR @Johann-S

@Herst Herst force-pushed the next-containers branch 2 times, most recently from 8ccb578 to 0baf007 Compare December 27, 2018 11:39
@Herst Herst force-pushed the next branch 2 times, most recently from dd8c5f2 to 0258293 Compare July 26, 2019 12:04
@Herst Herst force-pushed the next-containers branch from 807d433 to 94e9c8f Compare July 26, 2019 13:50
@Herst Herst requested review from XhmikosR and Johann-S July 26, 2019 15:08
@Herst Herst force-pushed the next-containers branch from 94e9c8f to e345eaa Compare July 26, 2019 15:19
@Herst Herst changed the title [v1] Container-related checks [v1] New container-related checks Jul 26, 2019
Port E003 (misplaced .row), and remove E004
(nestable containers).
@Herst Herst force-pushed the next-containers branch from e345eaa to a2ec396 Compare July 28, 2019 07:25
@Herst Herst removed the request for review from XhmikosR July 28, 2019 08:59
@Herst Herst merged commit 79ca109 into next Jul 28, 2019
@XhmikosR XhmikosR deleted the next-containers branch July 28, 2019 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants