Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use of @screen-xs-max in navbars.less #10371

Closed
bassjobsen opened this issue Sep 2, 2013 · 1 comment
Closed

use of @screen-xs-max in navbars.less #10371

bassjobsen opened this issue Sep 2, 2013 · 1 comment
Labels
confirmed css
Milestone
v3.0.1

Comments

@bassjobsen
Copy link
Contributor

@screen-xs-max is used to style the dropdown menus when collapsed. In the default situation this works cause @screen-xs-max = @grid-float-breakpoint-1 = 767. This breaks when changing @grid-float-breakpoint (b.e. to 0 for a non-responsive version).

Solution define a new variable: max(0,grid-float-breakpoint-1) and use this stead of screen-xs-max in navbars.less.

I don't know if the max() function works, see: less/less.js#1371
@bassjobsen bassjobsen mentioned this issue Sep 2, 2013
Closed
@mdo mdo mentioned this issue Sep 3, 2013
Closed
@bassjobsen bassjobsen mentioned this issue Sep 5, 2013
Closed
@cvrebert
Copy link
Collaborator

Closing in favor of your pull request.

@bassjobsen bassjobsen mentioned this issue Oct 14, 2013
Merged
mdo added a commit that referenced this issue Dec 5, 2013
@mdo
Fixes #11610: Add @grid-float-breakpoint-max to better link navbar be…
45930ac 
…havior across viewports and improve customization.

Also addresses #10371, #10395, and #10465.
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
@mdo
(less) Fixes twbs#11610: Add @grid-float-breakpoint-max to better lin…
71d3d5f 
…k navbar behavior across viewports and improve customization.

Also addresses twbs#10371, twbs#10395, and twbs#10465.
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#11610: Add @grid-float-breakpoint-max to better lin…
d5f5ccc 
…k navbar behavior across viewports and improve customization.

Also addresses twbs#10371, twbs#10395, and twbs#10465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed css
Projects
None yet
Milestone
v3.0.1
Development

No branches or pull requests
2 participants
@cvrebert @bassjobsen