-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use @grid-float-breakpoint-max #10465
Conversation
Just curious why this wasn't merged... is it not a valid issue? |
@bpugh It hasn't yet been merged, but it will be (or a substantially similar fix will be applied). |
@@ -248,7 +248,7 @@ | |||
@grid-gutter-width: 30px; | |||
// Point at which the navbar stops collapsing | |||
@grid-float-breakpoint: @screen-sm; | |||
|
|||
@grid-float-breakpoint-max: max(0,grid-float-breakpoint-1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a @
for grid-float-breakpoint
?
Also, there should be a space after the comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a "max" function listed at http://lesscss.org/#reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're adding one for v1.5 (https://github.com/less/less.js/blob/v1.5.0-b3/lib/less/functions.js#L311 ), but that's still in beta, and we're still stuck way back on v1.3.3 due to Recess.
So, this ain't gonna fly.
@@ -248,7 +248,16 @@ | |||
@grid-gutter-width: 30px; | |||
// Point at which the navbar stops collapsing | |||
@grid-float-breakpoint: @screen-sm; | |||
|
|||
//define @grid-float-breakpoint-max, always >= 0 | |||
.grid-float-breakpoint-max(@a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe call it @width
instead of @a
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this is more of a "clamped" than a "max".
This needs updating with master, the new variable added to the customizer, and then documented for it's own use somewhere as well. Also, your formatting is a little off from the rest of the framework so that opening curly braces are on the same line as the rule and no extra spaces appear between nested parens. |
Also bumping to 3.0.2 for now. |
We should also update the |
an other way to calculate max() in Less, see: http://stackoverflow.com/a/19386571/1596547:
|
@cvrebert I can make the update to Update: check out the diff https://github.com/thejameskyle/bootstrap/compare/patch-1 (the compiled file will have the correct max-width once this PR is merged) |
I still don't understand what you're trying to accomplish here. Compiling with Let's start fresh with a new PR and some more explanation around this. |
…k navbar behavior across viewports and improve customization. Also addresses twbs#10371, twbs#10395, and twbs#10465.
…k navbar behavior across viewports and improve customization. Also addresses twbs#10371, twbs#10395, and twbs#10465.
fix for issue #10371 (and #10395)