Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 - Accordion example uses v3 panel markup #17157

Closed
zacechola opened this issue Aug 20, 2015 · 3 comments
Closed

v4 - Accordion example uses v3 panel markup #17157

zacechola opened this issue Aug 20, 2015 · 3 comments

Comments

@zacechola
Copy link

http://v4-alpha.getbootstrap.com/components/collapse/#accordion-example

kkirsche added a commit to kkirsche/bootstrap that referenced this issue Aug 20, 2015
Partial Fix: twbs#17157

Additional code needed to get cards to butt up against each other as expected.
@tshinnic
Copy link
Contributor

Just noticed this now in recent sources, 2 months later, so would be nice to see this PR merged, especially if alpha2 is imminent.

However, and without trying @kkirsche 's fix, why does the Accordion example work without any of these old or new classes? They are only for the styling of appearance?

@tshinnic
Copy link
Contributor

Hmm, apparently not just styling, some behavior too. As it was, with no classes operative, the accordion was a single pane open at a time. If you clicked on another group item, it expanded while closing the previously open item. With kkirsche's fix, now you can open/close each group independently. This is radio button vs. checkbox behavior.

There are actually two behaviors possible - does the documentation say which behavior is available, or how to get either behavior?

@cvrebert
Copy link
Collaborator

Duplicate of #18375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants