-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 - Accordion example should use cards #17159
Conversation
Partial Fix: twbs#17157 Additional code needed to get cards to butt up against each other as expected.
You could use |
To me card text doesn't look right. If that's what people suggest I can but I personally don't find that to look like what I'd expect from an accordion. |
Hey guys, I am playing around with v4 and noticed that the funcitonality for accordian doesn't quite match the existing functionality. It seems that the accordian does not collapse open cards when you click on another card (note this seems to work as expected when using panels). See fiddle for example. http://v4-alpha.getbootstrap.com/components/collapse/#accordion-example Am I missing something? Maybe a setting? Thanks. |
Hi @ryannealmes! You appear to have posted a live example (https://fiddle.jshell.net/aswognd9/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
Different issue and there's a PR to address it I believe. |
Thanks, @mdo |
Partial Fix:
#17157#18375Additional code needed to get cards to butt up against each other as expected.Original (V3) isn't butted up against each other
Result:
