Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Default form style does not support label fully #8001

Closed
JensRantil opened this issue May 27, 2013 · 1 comment
Closed

Documentation: Default form style does not support label fully #8001

JensRantil opened this issue May 27, 2013 · 1 comment
Labels
Milestone

Comments

@JensRantil
Copy link

http://twitter.github.io/bootstrap/base-css.html#forms says the default for style is:

<form>
  <fieldset>
    <legend>Legend</legend>
    <label>Label name</label>
    <input type="text" placeholder="Type something…">
    <span class="help-block">Example block-level help text here.</span>
    <label class="checkbox">
      <input type="checkbox"> Check me out
    </label>
    <button type="submit" class="btn">Submit</button>
  </fieldset>
</form>

I propose the example is extended so

  • that the <input> is given an id attribute; and
  • the <label> tag also includes an for attribute that is bound to the input.

This will make the label clickable and improve usability.

@mdo
Copy link
Member

mdo commented Jun 20, 2013

Fixed in v3.

@mdo mdo closed this as completed Jun 20, 2013
mdo added a commit that referenced this issue Jun 20, 2013
seriema added a commit to seriema/bootstrap-grunt that referenced this issue Jun 21, 2013
* upstream/3.0.0-wip: (42 commits)
  Rename class name in placeholder
  Fixes twbs#8154: enforce full width `.navbar-nav.pull-right` in mobile
  Fixes twbs#8159: Be more specific about disabled inputs to avoid iOS bug
  Fixes twbs#8093: Removes invalid focus styles on inputs
  run make on previous commit
  Fixes twbs#7730: Better hiding of empty titles in popovers
  Run make on last commit
  Use `@font-family-base` for headings font-family variable
  run make on @nextgenthemes last commit
  rename '.navbar .nav' to '.navbar-nav'
  Add heading font family variable
  Offcanvas example update
  Fixes twbs#8001: add IDs for example inputs
  Add missing property to form-horizontal docs
  Add support for `tr`, `th`, and `td` to responsive utilities
  run make on last commit
  docs/javascript.html: backticks -> <code>
  Use correct font-size to calculate input-heights
  Addresses twbs#8199: darker default button
  Add note about Jekyll version per twbs#8195
  ...

Conflicts:
	README.md
	docs/assets/js/bootstrap.min.js
	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants