Prevent jekyll version mixup in docs #8195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
added a commit
that referenced
this pull request
Jun 18, 2013
|
Addressed the URL in #8182. And the Jekyll 1.x stuff can be a single inline note on step 1, so I've added that. Thanks! |
seriema
added a commit
to seriema/bootstrap-grunt
that referenced
this pull request
Jun 21, 2013
* upstream/3.0.0-wip: (42 commits) Rename class name in placeholder Fixes twbs#8154: enforce full width `.navbar-nav.pull-right` in mobile Fixes twbs#8159: Be more specific about disabled inputs to avoid iOS bug Fixes twbs#8093: Removes invalid focus styles on inputs run make on previous commit Fixes twbs#7730: Better hiding of empty titles in popovers Run make on last commit Use `@font-family-base` for headings font-family variable run make on @nextgenthemes last commit rename '.navbar .nav' to '.navbar-nav' Add heading font family variable Offcanvas example update Fixes twbs#8001: add IDs for example inputs Add missing property to form-horizontal docs Add support for `tr`, `th`, and `td` to responsive utilities run make on last commit docs/javascript.html: backticks -> <code> Use correct font-size to calculate input-heights Addresses twbs#8199: darker default button Add note about Jekyll version per twbs#8195 ... Conflicts: README.md docs/assets/js/bootstrap.min.js package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new docs do not publish to getbootstrap.dev:9001, they publish to localhost:9001. The "Customize and Download" button was fixed to handle this in 8158 but the docs were not updated.
There have been a number of comments (e.g. 8174) where people are trying to use the new Jekyll 1.x syntax with the old version of the library. This updates the docs to explain that the instructions are for 1.x as well as changing the link to point to localhost