Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Firefox bug with gradient backgrounds #11439

Closed
wants to merge 1 commit into from
Closed

Clean up Firefox bug with gradient backgrounds #11439

wants to merge 1 commit into from

Conversation

zlatanvasovic
Copy link

We removed the gradient from .btn, but we forget .navbar-toggle. Oh.

Don't merge so far!

@cvrebert
Copy link
Collaborator

Perhaps we should refactor .navbar-toggle to use a (new?) mixin to share code with .btn.

@zlatanvasovic
Copy link
Author

Ok, I'm marking a pull request with 'Don't merge so far' coz I'm working
on refactor. Good idea Chris.

2013/11/10 Chris Rebert [email protected]

Perhaps we should refactor .navbar-toggle to use a (new?) mixin to share
code with .btn.


Reply to this email directly or view it on GitHubhttps://github.com//pull/11439#issuecomment-28147440
.

Zlatan Vasović - ZDroid

@zlatanvasovic
Copy link
Author

@cvrebert Seems like we have same border and background-image values in toggles and buttons. Do we need to make mixin?

@mdo
Copy link
Member

mdo commented Nov 30, 2013

Resolved manually via 09cd528.

@mdo mdo closed this Nov 30, 2013
@zlatanvasovic zlatanvasovic deleted the clean-toggle branch November 30, 2013 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants