Add position utilities class #23095
Add position utilities class #23095
Conversation
scss/utilities/_position.scss
Outdated
| .pos-s { position: static; } | ||
| .pos-r { position: relative; } | ||
| .pos-a { position: absolute; } | ||
| .pos-f { position: fixed; } |
There was a problem hiding this comment.
Files should end with a trailing newline
…is the only one I found in the project, so I am assuming it is the right one to point to (#22895)
…ustom-checkbox-icon-checked`, `$custom-checkbox-indeterminate-bg`, `$custom-checkbox-icon-indeterminate`, `$custom-checkbox-indeterminate-box-shadow`, `$custom-radio-border-radius`, `$custom-radio-icon-checked` to `$custom-checkbox-indicator-border-radius`, `$custom-checkbox-indicator-icon-checked`, `$custom-checkbox-indicator-indeterminate-bg`, `$custom-checkbox-indicator-icon-indeterminate`, `$custom-checkbox-indicator-indeterminate-box-shadow`, `$custom-radio-indicator-border-radius`, `$custom-radio-indicator-icon-checked`, respectively
scss/utilities/_position.scss
Outdated
| @@ -23,3 +23,8 @@ | |||
| z-index: $zindex-sticky; | |||
| } | |||
| } | |||
|
|
|||
| .pos-s { position: static; } | |||
There was a problem hiding this comment.
You're missing position: sticky, which, with this naming scheme, would be problematic. We'll need that utility and a different name.
There was a problem hiding this comment.
You are right!
Could be a good naming scheme ?
pos-sti
pos-sta
pos-rel
pos-abs
pos-fix
There was a problem hiding this comment.
At that point, we might as well use the full value names. .p-sticky, .p-static, etc.
There was a problem hiding this comment.
Cool!
Thank you, I will a commit with this edit 🙂
There was a problem hiding this comment.
why not keep pos- or po- as prefix as p is use for padding ?
There was a problem hiding this comment.
Because there's no risk of overlap with padding—these values are unique to positioning.
|
I think your rebase went awry a bit :). |
|
ops, I'm sorry for that 🙁 |
|
I can squash as I merge when it comes to that :) |
|
Closing as this history got messed up. |
Utility class to set
positionproperty. Old PR #19292 with discussion. Fixes #18476.