Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position utilities class #23095

Closed
wants to merge 13 commits into from
Closed

Add position utilities class #23095

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a78a76e
Add position utilities class
CVarisco Jul 15, 2017
aa1c787
Fix code style houndci-bot
CVarisco Jul 15, 2017
d35020c
Update dependencies.
bardiharborow Jul 15, 2017
bde1652
Switch to using NPM lock files.
bardiharborow Jul 15, 2017
028863d
Fall back to ESLint v3 indentation behaviour.
bardiharborow Jul 15, 2017
a83a018
Errata from #23094.
bardiharborow Jul 16, 2017
21d8909
fix location of favicons so it loads when viewing the examples. This …
scottpetrovic Jul 16, 2017
696b2be
(#22414) Rename for consistency `$custom-checkbox-border-radius`, `$c…
pat270 Jul 14, 2017
082c9d9
dist
mdo Jul 16, 2017
c06d24d
Add position utilities class
CVarisco Jul 15, 2017
f98c6fa
Fix code style houndci-bot
CVarisco Jul 15, 2017
103ed75
Change scheme naming and add position sticky
CVarisco Jul 17, 2017
f4db7ba
Change scheme naming and add position sticky
CVarisco Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scss/utilities/_position.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,8 @@
z-index: $zindex-sticky;
}
}

.pos-s { position: static; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing position: sticky, which, with this naming scheme, would be problematic. We'll need that utility and a different name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right!
Could be a good naming scheme ?
pos-sti
pos-sta
pos-rel
pos-abs
pos-fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that point, we might as well use the full value names. .p-sticky, .p-static, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
Thank you, I will a commit with this edit 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not keep pos- or po- as prefix as p is use for padding ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there's no risk of overlap with padding—these values are unique to positioning.

.pos-r { position: relative; }
.pos-a { position: absolute; }
.pos-f { position: fixed; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline