Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example plugin: add data-example-id only if it's been supplied. #24127

Merged
merged 3 commits into from
Sep 27, 2017
Merged

example plugin: add data-example-id only if it's been supplied. #24127

merged 3 commits into from
Sep 27, 2017

Conversation

XhmikosR
Copy link
Member

My Ruby knowledge is pretty basic, but this seems to do the job.

@Johann-S
Copy link
Member

What's the goal of this PR @XhmikosR ?

@XhmikosR
Copy link
Member Author

Without this, we insert data-example-id whenever the example filter is being used even without id being passed as a parameter.

bardiharborow
bardiharborow approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@bardiharborow bardiharborow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Ruby is terrible too, but I think I can get away with reviewing a ternary operator. :)

@XhmikosR XhmikosR merged commit 6dd3d91 into v4-dev Sep 27, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-example-plugin branch September 27, 2017 10:08
@mdo mdo mentioned this pull request Sep 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeeton12 bkeeton12 bkeeton12 approved these changes

@bardiharborow bardiharborow bardiharborow approved these changes

@mdo mdo Awaiting requested review from mdo

@Johann-S Johann-S Awaiting requested review from Johann-S

Assignees
No one assigned
Labels
build v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XhmikosR @Johann-S @bardiharborow @bkeeton12