Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example plugin: add data-example-id only if it's been supplied. #24127

Merged
merged 3 commits into from
Sep 27, 2017
Merged

example plugin: add data-example-id only if it's been supplied. #24127

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c59b57
example plugin: add `data-example-id` only if it's been supplied.
XhmikosR Sep 26, 2017
514f71e
Merge branch 'v4-dev' into v4-dev-xmr-example-plugin
XhmikosR Sep 26, 2017
64c4357
Merge branch 'v4-dev' into v4-dev-xmr-example-plugin
XhmikosR Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _plugins/example.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def initialize(tag_name, markup, tokens)

#{markup}

Valid syntax: example <lang>
Valid syntax: example <lang> [id=foo]
eos
end
end
Expand All @@ -55,7 +55,7 @@ def render(context)
end

def example(output)
"<div class=\"bd-example\" data-example-id=\"#{@options[:id]}\">\n#{output}\n</div>"
"<div class=\"bd-example\"" + (@options[:id] ? " data-example-id=\"#{@options[:id]}\"" : "") + ">\n#{output}\n</div>"
end

def remove_holderjs(code)
Expand Down