tests/RunTests.hs: fix failure tests #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem description by Andreas Herrmann: > run-tests -m '/failures/' doesn't seem to be working as expected. > The test should attempt to build all targets under > //tests/failures/... that are marked with the manual tag and expect > them to fail. However, if I add the manual tag to a suceeding target > e.g. //tests/failures/transitive-deps:lib-c, then the overall test > still suceeds. Manually tested via description that a succeeding test now actually fails. Fixes #943
jwiegley
force-pushed
the
tests-run-tests-fix-failures
branch
from
953f710 to
8a3d3e2
Compare
This was referenced Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description by Andreas Herrmann:
Manually tested via description that a succeeding test now actually
fails.
Fixes #943