Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LANG=C.UTF-8 in Nix shell #1118

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Set LANG=C.UTF-8 in Nix shell #1118

merged 1 commit into from
Oct 10, 2019

Conversation

aherrmann
Copy link
Member

This is to fix CI failures on run-tests -m failures, see #1117 (comment):

Failures:
--
  |  
  | tests/RunTests.hs:70:7:
  | 1) failures //tests/failures/transitive-deps:lib-dFailure
  | uncaught exception: IOException of type InvalidArgument
  | fd:15: hGetContents: invalid argument (invalid byte sequence)
  |  
  | To rerun use: --match "/failures///tests/failures/transitive-deps:lib-dFailure/"
  |  
  | tests/RunTests.hs:70:7:
  | 2) failures //tests/failures/transitive-deps:lib-cFailure
  | uncaught exception: IOException of type InvalidArgument
  | fd:15: hGetContents: invalid argument (invalid byte sequence)
  |  
  | To rerun use: --match "/failures///tests/failures/transitive-deps:lib-cFailure/"

That failure already exists on master since #1115 see CI runs #424 and #426. So, it seems to be unrelated to this PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aherrmann aherrmann requested a review from Profpatsch October 9, 2019 16:34
@mboes
Copy link
Member

mboes commented Oct 9, 2019

@Profpatsch is C.utf8 an option here?

@aherrmann
Copy link
Member Author

@mboes See #1099 which switched from en_US.UTF-8 to C.UTF-8.

@Profpatsch
Copy link
Contributor

@Profpatsch is C.utf8 an option here?

yep, C.UTF8 is something that glibc added a while ago. You don’t need those pesky locale archives for basic UTF8 support now.

Copy link
Contributor

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set it on the socket inside of RunTests.hs

@Profpatsch Profpatsch self-requested a review October 10, 2019 11:19
Copy link
Contributor

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, we don’t gain that much from it, so let’s do this.

@Profpatsch Profpatsch added the merge-queue merge on green CI label Oct 10, 2019
@mergify mergify bot merged commit 356ffd6 into master Oct 10, 2019
@mergify mergify bot deleted the fix-utf-8-issue branch October 10, 2019 11:22
@mergify mergify bot removed the merge-queue merge on green CI label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants