Strip down integer ticket numbers #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 95.32% 95.37% +0.04%
==========================================
Files 20 20
Lines 1027 1038 +11
Branches 104 104
==========================================
+ Hits 979 990 +11
Misses 27 27
Partials 21 21
Continue to review full report at Codecov.
|
adiroiban
reviewed
Dec 3, 2020
| @@ -66,3 +66,15 @@ def test_dots_in_ticket_name_and_counter(self): | |||
| parse_newfragment_basename("baz.1.2.feature.3", ["feature"]), | |||
| ("2", "feature", 3), | |||
| ) | |||
|
|
|||
| def test_strip(self): | |||
| self.assertEqual( | |||
There was a problem hiding this comment.
Minor comment
would be nice to have a docstring explaing the scope/purpose/expectation of this test :)
This can serve as the developer documentation for this feature.
There was a problem hiding this comment.
"""Leading spaces and subsequent leading zeros are stripped
when parsing newsfragment names into ticket numbers etc.
"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126 .