-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip down integer ticket numbers #278
Merged
altendky
merged 8 commits into
twisted:master
from
altendky:126-strip_leading_zeros_on_issues
Dec 8, 2020
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0d97aa7
Strip down integer ticket numbers
altendky 3b42c98
Update test_builder.py
altendky 68b8787
Merge branch 'master' into 126-strip_leading_zeros_on_issues
altendky 4505336
Merge branch 'master' into 126-strip_leading_zeros_on_issues
altendky e78cf35
Merge branch 'master' into 126-strip_leading_zeros_on_issues
altendky fd6288c
Add docstring for new test for the strip feature
altendky cc26684
Merge branch 'master' into 126-strip_leading_zeros_on_issues
altendky a20ebd6
Merge branch 'master' into 126-strip_leading_zeros_on_issues
altendky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Ticket number from file names will be stripped down to avoid ticket links such as ``#007``. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
would be nice to have a docstring explaing the scope/purpose/expectation of this test :)
This can serve as the developer documentation for this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/twisted/towncrier/pull/278/files#diff-b7254cf4717de60e5d2e57233db4f5cbb47871439b71f2280bed581ff9fcf851R71-R73