Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight could be specified as a function #1101

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

n9
Copy link

@n9 n9 commented Jan 19, 2015

  • to allow custom matching (for instance multiple matches, etc)

@erikreedstrom
Copy link

We just had this conversation and came to the same conclusion. +1
However, there is a use case for also passing the suggestions in the method. For instance, we query the Places API, and the results have their own match strings which could be provided as patterns.

@@ -1206,7 +1206,7 @@
that.highlight && highlight({
className: "tt-highlight",
node: $suggestions[0],
pattern: query
pattern: _.isFunction(that.highlight) ? that.highlight(query) : query

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would call with signature of that.highlight(query, suggestions) as the results may not correlate directly with the query, for instance misspellings corrected with Levenshtein distance.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


n9 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants