-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight could be specified as a function #1101
base: master
Are you sure you want to change the base?
Conversation
n9
commented
Jan 19, 2015
- to allow custom matching (for instance multiple matches, etc)
We just had this conversation and came to the same conclusion. +1 |
@@ -1206,7 +1206,7 @@ | |||
that.highlight && highlight({ | |||
className: "tt-highlight", | |||
node: $suggestions[0], | |||
pattern: query | |||
pattern: _.isFunction(that.highlight) ? that.highlight(query) : query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would call with signature of that.highlight(query, suggestions)
as the results may not correlate directly with the query, for instance misspellings corrected with Levenshtein distance.
Added suggestions to highlight method signature
n9 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |